Attention is currently required from: Lance Zhao, Furquan Shaikh, Tim Wawrzynczak. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55027 )
Change subject: acpi/device: Add ability to generate proper _STA for PowerResource ......................................................................
Patch Set 2:
(1 comment)
File src/acpi/device.c:
https://review.coreboot.org/c/coreboot/+/55027/comment/826d982c_3e9eb035 PS1, Line 605: acpigen_write_method
If you're going to go with reading GPIOs, this needs to be Serialized, so it won't run with _ON or _ […]
Ah, good catch!
We would still need code to set the initial state, and at that point, I don't really think having local state buys us much. It doesn't reduce the complexity of the code. PowerResources are not toggled often enough for a few extra instructions to make a difference.