Change in coreboot[master]: Revert "libpayload/keyboard: Reset to scancode set #2 on exit" - coreboot-gerrit

30 Apr 2021


      Attention is currently required from: Nico Huber, Angel Pons, Duncan Laurie.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52432 )
Change subject: Revert "libpayload/keyboard: Reset to scancode set #2 on exit"
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
...
I'd prefer this as well.
I just tried it and it made this error go away:
[ 3425.046782] atkbd serio0: Use 'setkeycodes e035 <keycode>' to make it known.
[ 3425.127573] atkbd serio0: Unknown key pressed (raw set 2, code 0xb5 on isa0060/serio0).
but I don't get any keys when I do evtest :(
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/52432
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ice5057ab0b764d784b172f09aeacabaa4e74f34f
Gerrit-Change-Number: 52432
Gerrit-PatchSet: 1
Gerrit-Owner: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Duncan Laurie dlaurie@gmail.com
Gerrit-CC: Duncan Laurie duncan@iceblink.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Duncan Laurie dlaurie@gmail.com
Gerrit-Comment-Date: Fri, 30 Apr 2021 17:48:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Comment-In-Reply-To: Duncan Laurie dlaurie@gmail.com
Gerrit-MessageType: comment