Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48090 )
Change subject: soc/intel/common/block/gpio: add code for NMI enabling ......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48090/10/src/soc/intel/skylake/acpi... File src/soc/intel/skylake/acpi.c:
https://review.coreboot.org/c/coreboot/+/48090/10/src/soc/intel/skylake/acpi... PS10, Line 526: 5,
mh, LINT1 is a ISA interrupt (see IOAPIC spec) - and ISA interrupts are always edge/active-high acco […]
Ack
https://review.coreboot.org/c/coreboot/+/48090/10/src/soc/intel/skylake/acpi... PS10, Line 526: 1)
yes, see IOAPIC spec
thanks for the pointer.