Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40955 )
Change subject: payloads/external/GRUB2: prevent rebuild without actual changes
......................................................................
Patch Set 5: Code-Review-1
(1 comment)
https://review.coreboot.org/c/coreboot/+/40955/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/40955/4//COMMIT_MSG@10
PS4, Line 10: caused by Make detecting a change in the dependency on the config file.
This is the intended behaviour. If the coreboot config changes,
it can mean that a different revision of GRUB is to be built, for
instance.
If that is the case (GRUB's config is affected by coreboot's) is
hard to track in `make`. One way would be to write a file with
coreboot's configuration values that affect GRUB. Then only update
that file if its contents would change and have a dependency on
that file.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40955
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibf5a316d0c9761426ec2ee306d78cd56d4bf19b5
Gerrit-Change-Number: 40955
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Denis Carikli
GNUtoo@no-log.org
Gerrit-Reviewer: Jonathan Neuschäfer
j.neuschaefer@gmx.net
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 04 May 2020 22:32:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment