Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49134 )
Change subject: mb/google/dedede: Disable Fast slew rate for deeper c states
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/49134/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/49134/2//COMMIT_MSG@9
PS2, Line 9: We need to disable fast slew rate for deeper package C states
: while enabling acoustic noise mitigations.
Is this always the case? If so, I'd suggest handling this in SoC code instead.
This is only applicable if we enable acoustic noise mitigation from board. This is the reason for keeping it in mainboard where we enable Acoustic Noise mitigation feature.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49134
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie42c8ab647ff42fa043b6f717a9834f9b9c551f6
Gerrit-Change-Number: 49134
Gerrit-PatchSet: 2
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Divagar Mohandass
divagar.mohandass@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 06 Jan 2021 16:34:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment