Attention is currently required from: Maulik V Vaghela, Mario Scheithauer, Subrata Banik, Lean Sheng Tan, Patrick Rudolph.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54959 )
Change subject: soc/intel/elkhartlake: Update FSP-S UPD LPSS related configs
......................................................................
Patch Set 9:
(2 comments)
File src/mainboard/intel/elkhartlake_crb/variants/ehlcrb/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/54959/comment/d2a21af7_badebba9
PS9, Line 54: [PchSerialIoIndexI2C7] = PchSerialIoPci,
Will there be more than 7? If not, please only use one space before the =.
https://review.coreboot.org/c/coreboot/+/54959/comment/ae025ce6_cecb9225
PS9, Line 112: device pci 09.0 off end # CPU Intel Trace Hub
Unrelated, please the inconsistency of using spaces/tabs before end in a separate commit.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54959
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib0c3cd1d37ff9892d09d6d86ac50e230549c7e53
Gerrit-Change-Number: 54959
Gerrit-PatchSet: 9
Gerrit-Owner: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 28 May 2021 06:38:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment