Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29662 )
Change subject: {drivers,soc/intel/braswell}: Add C_ENVIRONMENT_BOOTBLOCK support
......................................................................
Patch Set 27:
(1 comment)
https://review.coreboot.org/#/c/29662/27/src/drivers/intel/fsp1_1/car.c
File src/drivers/intel/fsp1_1/car.c:
https://review.coreboot.org/#/c/29662/27/src/drivers/intel/fsp1_1/car.c@105
PS27, Line 105: car_soc_pre_console_init();
: car_mainboard_pre_console_init();
console_init also happens in the bootblock, therefore you want to initialise SPI and LPC in the boot […]
The init in car_soc_XXXX_console_init() are not related to console on Braswell (at least then when using external UART). For this reason console is working in bootblock without problems.
Have moved the code in car_soc_XXXX_console_init() to bootblock_soc_init() and bootblock_soc_early_init().
Will upload new patch set.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29662
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iab48ad72f1514c93f20d70db5ef4fd8fa2383e8c
Gerrit-Change-Number: 29662
Gerrit-PatchSet: 27
Gerrit-Owner: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: York Yang
yyang024@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 23 May 2019 10:29:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Frans Hendriks
fhendriks@eltan.com
Gerrit-MessageType: comment