Attention is currently required from: Eric Lai.
Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75700?usp=email )
Change subject: mb/google/myst: Update PCIE_RST_L drive ......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/myst/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/75700/comment/7d1fccbb_767e7830 : PS2, Line 55: PAD_NF(GPIO_27, PCIE_RST1_L, PULL_NONE),
maybe also give the reason why in romstage is output here is NF.
It was an intended change, but leaving it as an output low is likely equivalent. I can put that back.
I don't understand your second comment. This is the only place that we modify GPIO_27. If you look at the schematic, it's actually just attached to an external pull down
-
Jon Murphy (Code Review)