Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Paul Menzel. Sugnan Prabhu S has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56750 )
Change subject: wifi: Add support for new SAR tables revisions ......................................................................
Patch Set 18:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56750/comment/8cdb6bd7_4e5bb533 PS17, Line 7: vc/google/chromeos
This is touching more than just vc/google/chromeos.
Ack
File src/include/sar.h:
https://review.coreboot.org/c/coreboot/+/56750/comment/ce5d9ee6_e6d50d81 PS17, Line 51: sar_limit
I think you meant sar_limit[0] to indicate that this is a variable-length array. […]
Ack
File src/vendorcode/google/chromeos/sar.c:
https://review.coreboot.org/c/coreboot/+/56750/comment/2497cfd3_e6d10977 PS17, Line 138: if (CONFIG(USE_SAR)) { : sar_limits->sar_table->version = 0; : sar_limits->sar_table->sar_enable = CONFIG(SAR_ENABLE); : sar_limits->sar_table->dsar_enable = CONFIG(DSAR_ENABLE); : sar_limits->sar_table->dsar_set_num = CONFIG_DSAR_SET_NUM; : }
I will update the logic to remove USE_SAR_V2. […]
Hi Furquan, Currently none of the revision combinations is creating a hex file of size 119 or 81. But if at all in future on adding more ACPI objects, if we get a size of 119 or 81, we can check this in hex generator code and add "$SAR" at the end of the file so that when a size mismatch is observed, we can check if the expected length matches with size + 4 and last 4 bytes are "$SAR"
Let me know your thoughts.
-
Sugnan Prabhu S (Code Review)