Change in coreboot[master]: vc/google/chromeos: Add support for new SAR tables revisions

[Sugnan Prabhu S (Code Review)]

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Paul Menzel.
Sugnan Prabhu S has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56750 )

Change subject: vc/google/chromeos: Add support for new SAR tables revisions
......................................................................

Patch Set 14:

(11 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/56750/comment/10dfda9b_1c4b141f 
PS12, Line 14: wdgs
> WGDS

Done

https://review.coreboot.org/c/coreboot/+/56750/comment/b5db8ed4_7b87e10d 
PS12, Line 15: wdgs
> WGDS

Done

https://review.coreboot.org/c/coreboot/+/56750/comment/c03aefdb_afd3107e 
PS12, Line 22: TEST=Checked the SSDT entries for WRDS, EWRD, WGDS and PPAG with
             : different binaries generated by setting different versions in the
             : config.star
> Does this mean you verified revisions 0, 1 and 2 are all generated and decoded correctly?

Yes it was verified with most of the combinations.

Patchset:

PS8:
> Hi Tim, […]

Ack

File src/drivers/wifi/generic/acpi.c:

https://review.coreboot.org/c/coreboot/+/56750/comment/6635e46f_eb07ddfd 
PS12, Line 55: 	if (sar_table->version > 2) {
             : 		printk(BIOS_ERR, "Invalid SAR table version: %x02\n", sar_table->version);
             : 		return;
             : 	}
> suggestion: move this to an `else` clause after line 75, e.g.: […]

Done

https://review.coreboot.org/c/coreboot/+/56750/comment/9b28a956_e0bb6e83 
PS12, Line 141: wgds
> WGDS

Done

File src/include/sar.h:

https://review.coreboot.org/c/coreboot/+/56750/comment/be5b9760_a5036f7f 
PS12, Line 7: #define NUM_SAR_LIMITS 4
            : #define BYTES_PER_SAR_LIMIT 10
            : #define BYTES_PER_SAR_LIMIT_REV1 22
            : #define BYTES_PER_SAR_LIMIT_REV2 (BYTES_PER_SAR_LIMIT_REV1 * 2)
            : #define ANT_GAINS_TABLE_COUNT 2
            : #define REVISION_SIZE 1
            : #define PPAG_MODE_SIZE 1
> nit: line these all up on the right side

Done

File src/vendorcode/google/chromeos/sar_v2.c:

PS12:
> Tim, […]

Ack

https://review.coreboot.org/c/coreboot/+/56750/comment/4bbd9ec9_dcd891a1 
PS12, Line 14: if (sar_table->version == 0)
             : 		return BYTES_PER_SAR_LIMIT * NUM_SAR_LIMITS + REVISION_SIZE;
             : 	else if (sar_table->version == 1)
             : 		return BYTES_PER_SAR_LIMIT_REV1 * NUM_SAR_LIMITS + REVISION_SIZE;
             : 	else if (sar_table->version == 2)
             : 		return BYTES_PER_SAR_LIMIT_REV2 * NUM_SAR_LIMITS + REVISION_SIZE;
             : 	else
             : 		return REVISION_SIZE;
> with above, e.g. […]

Done

https://review.coreboot.org/c/coreboot/+/56750/comment/836b5498_fdc12c08 
PS12, Line 24: wgds_table_size
> similar here

Done

https://review.coreboot.org/c/coreboot/+/56750/comment/ccff4b61_4ada21ef 
PS12, Line 34: antgains_table_size
> would just return `0` for USE_SAR

Done