Attention is currently required from: Matt DeVillier.
Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/80705?usp=email )
Change subject: mb/starlabs/byte_adl: Add Alder Lake N Byte Mk II ......................................................................
Patch Set 7:
(3 comments)
File src/mainboard/starlabs/byte_adl/cmos.default:
https://review.coreboot.org/c/coreboot/+/80705/comment/39eb4399_d21a99be?usp... : PS7, Line 9: Balanced
for a device which is always connected to external power, any reason to not use performance here?
For most no, but some people care about power consumption and heat on these (they're fanless)
File src/mainboard/starlabs/byte_adl/variants/mk_ii/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/80705/comment/b6fac31f_84068d73?usp... : PS7, Line 4: SaGv_Enabled
necessary/desired for a desktop device? setting to highest freq only should save some RAM training t […]
You mean remove it? I thought it didn't limit performance
https://review.coreboot.org/c/coreboot/+/80705/comment/127bc728_b24fb5b4?usp... : PS7, Line 143: end
EC interface isn't used for fan control etc?
There's no fan, EC controls the power button and power sequence, nothing else
-
Sean Rhodes (Code Review)