Attention is currently required from: Arthur Heymans, Julius Werner, Kapil Porwal.
Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/81968?usp=email )
Change subject: libpayload: Add x86_64 (64-bit) support ......................................................................
Patch Set 65:
(1 comment)
File payloads/libpayload/arch/x86/head_32.S:
https://review.coreboot.org/c/coreboot/+/81968/comment/eaab6a6e_757e31a5?usp... : PS54, Line 40: #endif
Yes, but that comment was made when the plan was still to have (only) a 64-bit entry point. Multiboot is (as far as I understand) a 32-bit only hand-off API so it wouldn't have made sense for that case. But now that we've decided to have a 32-bit entry point and switch modes within the payload, I don't see why it couldn't support multiboot.
I'm not asking you to do any major work or test this or anything. Just keep including the same multiboot header from `head_64.S` (after the EFER check in the 32-bit path).
for sure, I had an impression, you are asking to add it for 64-bit.
-
Subrata Banik (Code Review)