build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26353 )
Change subject: device/oprom/x86emu/prim_ops.c: Fix coding style ......................................................................
Patch Set 7:
(83 comments)
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c File src/device/oprom/x86emu/prim_ops.c:
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@7... PS7, Line 760: if ((cnt = s % 9) != 0) { do not use assignment in if condition
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@7... PS7, Line 781: if (ACCESS_FLAG(F_CF)) { /* carry flag is set */ suspect code indent for conditional statements (16, 32)
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@8... PS7, Line 807: if ((cnt = s % 17) != 0) { do not use assignment in if condition
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@8... PS7, Line 812: if (ACCESS_FLAG(F_CF)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@8... PS7, Line 831: if ((cnt = s % 33) != 0) { do not use assignment in if condition
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@8... PS7, Line 878: if ((cnt = s % 9) != 0) { do not use assignment in if condition
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@8... PS7, Line 883: /* note hackery here. Access_flag(..) evaluates to either line over 80 characters
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@9... PS7, Line 942: if ((cnt = s % 17) != 0) { do not use assignment in if condition
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@9... PS7, Line 951: if (ACCESS_FLAG(F_CF)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@9... PS7, Line 974: if ((cnt = s % 33) != 0) { do not use assignment in if condition
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1... PS7, Line 1021: if ((cnt = s % 8) != 0) { do not use assignment in if condition
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1... PS7, Line 1054: if ((cnt = s % 16) != 0) { do not use assignment in if condition
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1... PS7, Line 1079: if ((cnt = s % 32) != 0) { do not use assignment in if condition
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1... PS7, Line 1119: if ((cnt = s % 8) != 0) { /* not a typo, do nada if cnt==0 */ do not use assignment in if condition
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1... PS7, Line 1150: if ((cnt = s % 16) != 0) { do not use assignment in if condition
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1... PS7, Line 1173: if ((cnt = s % 32) != 0) { do not use assignment in if condition
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1... PS7, Line 1214: } else { code indent should use tabs where possible
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1... PS7, Line 1214: } else { please, no spaces at the start of a line
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1... PS7, Line 1250: } else { code indent should use tabs where possible
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1... PS7, Line 1250: } else { please, no spaces at the start of a line
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1... PS7, Line 1283: CONDITIONAL_SET_FLAG((((res & 0x80000000) == 0x80000000) ^ line over 80 characters
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1... PS7, Line 1285: } else { code indent should use tabs where possible
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1... PS7, Line 1285: } else { please, no spaces at the start of a line
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1... PS7, Line 1318: if (cnt == 1) { braces {} are not necessary for any arm of this statement
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1... PS7, Line 1320: } else { code indent should use tabs where possible
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1... PS7, Line 1320: } else { please, no spaces at the start of a line
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1... PS7, Line 1353: if (cnt == 1) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1... PS7, Line 1355: } else { code indent should use tabs where possible
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1... PS7, Line 1355: } else { please, no spaces at the start of a line
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1... PS7, Line 1355: } else { space required after that close brace '}'
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1... PS7, Line 1355: } else { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1... PS7, Line 1387: if (cnt == 1) { braces {} are not necessary for any arm of this statement
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1... PS7, Line 1389: } else { code indent should use tabs where possible
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1... PS7, Line 1389: } else { please, no spaces at the start of a line
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1... PS7, Line 1419: if (sf) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1... PS7, Line 1536: } else { code indent should use tabs where possible
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1... PS7, Line 1536: } else { please, no spaces at the start of a line
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1... PS7, Line 1569: CONDITIONAL_SET_FLAG((((res & 0x80000000) == 0x80000000) ^ line over 80 characters
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1... PS7, Line 1571: } else { code indent should use tabs where possible
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1... PS7, Line 1571: } else { please, no spaces at the start of a line
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1... PS7, Line 1604: if (cnt == 1) { braces {} are not necessary for any arm of this statement
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1... PS7, Line 1606: } else { code indent should use tabs where possible
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1... PS7, Line 1606: } else { please, no spaces at the start of a line
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1... PS7, Line 1638: if (cnt == 1) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1... PS7, Line 1640: } else { code indent should use tabs where possible
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1... PS7, Line 1640: } else { please, no spaces at the start of a line
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1... PS7, Line 1640: } else { space required after that close brace '}'
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1... PS7, Line 1640: } else { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1... PS7, Line 1663: if (ACCESS_FLAG(F_CF)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1... PS7, Line 1665: } else { code indent should use tabs where possible
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1... PS7, Line 1665: } else { please, no spaces at the start of a line
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1... PS7, Line 1665: } else { space required after that close brace '}'
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1... PS7, Line 1665: } else { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1... PS7, Line 1687: if (ACCESS_FLAG(F_CF)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1... PS7, Line 1689: } else { code indent should use tabs where possible
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1... PS7, Line 1689: } else { please, no spaces at the start of a line
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1... PS7, Line 1689: } else { space required after that close brace '}'
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1... PS7, Line 1689: } else { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1... PS7, Line 1711: if (ACCESS_FLAG(F_CF)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1... PS7, Line 1713: } else { code indent should use tabs where possible
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1... PS7, Line 1713: } else { please, no spaces at the start of a line
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1... PS7, Line 1713: } else { space required after that close brace '}'
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1... PS7, Line 1713: } else { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1... PS7, Line 1929: if ((d_sign = d & 0x80000000) != 0) do not use assignment in if condition
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@1... PS7, Line 1933: if ((s_sign = s & 0x80000000) != 0) do not use assignment in if condition
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@2... PS7, Line 2297: } else if (size == 2) { code indent should use tabs where possible
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@2... PS7, Line 2297: } else if (size == 2) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@2... PS7, Line 2297: } else if (size == 2) { space required after that close brace '}'
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@2... PS7, Line 2300: } else { code indent should use tabs where possible
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@2... PS7, Line 2300: } else { please, no spaces at the start of a line
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@2... PS7, Line 2300: } else { space required after that close brace '}'
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@2... PS7, Line 2310: if (ACCESS_FLAG(F_DF)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@2... PS7, Line 2345: } else { code indent should use tabs where possible
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@2... PS7, Line 2345: } else { please, no spaces at the start of a line
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@2... PS7, Line 2345: } else { space required after that close brace '}'
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@2... PS7, Line 2355: if (ACCESS_FLAG(F_DF)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@2... PS7, Line 2368: if (M.x86.mode & SYSMODE_32BIT_REP) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@2... PS7, Line 2464: /* Regardless if we have real data from the hardware, the emulator line over 80 characters
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@2... PS7, Line 2465: * will only support upto feature 1, which we set in register EAX. line over 80 characters
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@2... PS7, Line 2475: /* If we don't have x86 compatible hardware, we return values from an line over 80 characters
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@2... PS7, Line 2476: * Intel 486dx4; which was one of the first processors to have CPUID. line over 80 characters
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@2... PS7, Line 2482: /* In the case that we have hardware CPUID instruction, we make sure line over 80 characters
https://review.coreboot.org/#/c/26353/7/src/device/oprom/x86emu/prim_ops.c@2... PS7, Line 2489: * return all zeros when queried for invalid or unsupported feature line over 80 characters
-
build bot (Jenkins) (Code Review)