Change in ...coreboot[master]: libpayload: remove re-initialization of uart in libpayload
Nitheesh Sekar has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33424
Change subject: libpayload: remove re-initialization of uart in libpayload ......................................................................
libpayload: remove re-initialization of uart in libpayload
Depend on the coreboot for initialization of UART instead of re-initialising in libpayload.
Change-Id: I7820bd7afd2e5f81e21a43f330ed42d3a732d577 Signed-off-by: Prudhvi Yarlagadda pyarlaga@codeaurora.org --- M payloads/libpayload/drivers/serial/qcs405.c 1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/33424/1
diff --git a/payloads/libpayload/drivers/serial/qcs405.c b/payloads/libpayload/drivers/serial/qcs405.c index 9f02e17..7a80aae 100644 --- a/payloads/libpayload/drivers/serial/qcs405.c +++ b/payloads/libpayload/drivers/serial/qcs405.c @@ -547,8 +547,10 @@
uart_board_param.uart_dm_base = (void *)(uintptr_t)sc_ptr->baseaddr;
- /* TODO: We should rely on coreboot init. */ - msm_boot_uart_dm_init(uart_board_param.uart_dm_base); + /* We should re-initialise uart rx as it gets reset in coreboot. */ + write32(MSM_BOOT_UART_DM_IMR(uart_board_param.uart_dm_base), + MSM_BOOT_UART_DM_IMR_ENABLED); + msm_boot_uart_dm_init_rx_transfer(uart_board_param.uart_dm_base);
console_add_output_driver(&consout); console_add_input_driver(&consin);
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33424 )
Change subject: libpayload: remove re-initialization of uart in libpayload ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
code looks good, but the commit message isn't correct anymore
https://review.coreboot.org/#/c/33424/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/33424/1//COMMIT_MSG@7 PS1, Line 7: remove re-initialization of uart in libpayload : : Depend on the coreboot for initialization of UART instead of : re-initialising in libpayload. : please update the commit message to match the change
Hello build bot (Jenkins), Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33424
to look at the new patch set (#2).
Change subject: libpayload: Re-initialize UART RX ......................................................................
libpayload: Re-initialize UART RX
UART RX needs to be re-initialized in libpayload as it is getting reset at the end of coreboot.
Change-Id: I7820bd7afd2e5f81e21a43f330ed42d3a732d577 Signed-off-by: Prudhvi Yarlagadda pyarlaga@codeaurora.org --- M payloads/libpayload/drivers/serial/qcs405.c 1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/33424/2
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33424 )
Change subject: libpayload: Re-initialize UART RX ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33424 )
Change subject: libpayload: Re-initialize UART RX ......................................................................
libpayload: Re-initialize UART RX
UART RX needs to be re-initialized in libpayload as it is getting reset at the end of coreboot.
Change-Id: I7820bd7afd2e5f81e21a43f330ed42d3a732d577 Signed-off-by: Prudhvi Yarlagadda pyarlaga@codeaurora.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/33424 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com --- M payloads/libpayload/drivers/serial/qcs405.c 1 file changed, 4 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved
diff --git a/payloads/libpayload/drivers/serial/qcs405.c b/payloads/libpayload/drivers/serial/qcs405.c index 9f02e17..7a80aae 100644 --- a/payloads/libpayload/drivers/serial/qcs405.c +++ b/payloads/libpayload/drivers/serial/qcs405.c @@ -547,8 +547,10 @@
uart_board_param.uart_dm_base = (void *)(uintptr_t)sc_ptr->baseaddr;
- /* TODO: We should rely on coreboot init. */ - msm_boot_uart_dm_init(uart_board_param.uart_dm_base); + /* We should re-initialise uart rx as it gets reset in coreboot. */ + write32(MSM_BOOT_UART_DM_IMR(uart_board_param.uart_dm_base), + MSM_BOOT_UART_DM_IMR_ENABLED); + msm_boot_uart_dm_init_rx_transfer(uart_board_param.uart_dm_base);
console_add_output_driver(&consout); console_add_input_driver(&consin);
-
Nitheesh Sekar (Code Review) -
Patrick Georgi (Code Review)