David Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46592 )
Change subject: mb/google/volteer/var/terrador: Disable SRCCLKREQ1# ......................................................................
mb/google/volteer/var/terrador: Disable SRCCLKREQ1#
Disable SRCCLKREQ1# for terrador and todor.
BUG=b:171278849 BRANCH=none TEST=none
Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com Change-Id: I5f7734d64390bfadbdb8d152261103adb8e75f40 --- M src/mainboard/google/volteer/variants/terrador/overridetree.cb M src/mainboard/google/volteer/variants/todor/overridetree.cb 2 files changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/46592/1
diff --git a/src/mainboard/google/volteer/variants/terrador/overridetree.cb b/src/mainboard/google/volteer/variants/terrador/overridetree.cb index 1ccdb87..a4112f0 100644 --- a/src/mainboard/google/volteer/variants/terrador/overridetree.cb +++ b/src/mainboard/google/volteer/variants/terrador/overridetree.cb @@ -16,6 +16,9 @@
register "SaGv" = "SaGv_Disabled"
+ # Disable SRCCLKREQ1# + register "PcieClkSrcUsage[1]" = "0xFF" + device domain 0 on device ref i2c0 on chip drivers/i2c/generic diff --git a/src/mainboard/google/volteer/variants/todor/overridetree.cb b/src/mainboard/google/volteer/variants/todor/overridetree.cb index 1ccdb87..a4112f0 100644 --- a/src/mainboard/google/volteer/variants/todor/overridetree.cb +++ b/src/mainboard/google/volteer/variants/todor/overridetree.cb @@ -16,6 +16,9 @@
register "SaGv" = "SaGv_Disabled"
+ # Disable SRCCLKREQ1# + register "PcieClkSrcUsage[1]" = "0xFF" + device domain 0 on device ref i2c0 on chip drivers/i2c/generic
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46592 )
Change subject: mb/google/volteer/var/terrador: Disable SRCCLKREQ1# ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46592/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46592/1//COMMIT_MSG@9 PS1, Line 9: Disable SRCCLKREQ1# for terrador and todor. Please add the motivation for disabling this.
Hello build bot (Jenkins), Derek Huang,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46592
to look at the new patch set (#2).
Change subject: mb/google/volteer/var/terrador: Disable SRCCLKREQ1# ......................................................................
mb/google/volteer/var/terrador: Disable SRCCLKREQ1#
According to the schematic,SRCCLKREQ1# is not connected, so disable it for terrador and todor.
BUG=b:171278849 BRANCH=none TEST=none
Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com Change-Id: I5f7734d64390bfadbdb8d152261103adb8e75f40 --- M src/mainboard/google/volteer/variants/terrador/overridetree.cb M src/mainboard/google/volteer/variants/todor/overridetree.cb 2 files changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/46592/2
David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46592 )
Change subject: mb/google/volteer/var/terrador: Disable SRCCLKREQ1# ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46592/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46592/1//COMMIT_MSG@9 PS1, Line 9: Disable SRCCLKREQ1# for terrador and todor.
Please add the motivation for disabling this.
Done
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46592 )
Change subject: mb/google/volteer/var/terrador: Disable SRCCLKREQ1# ......................................................................
Patch Set 2: Code-Review+2
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46592 )
Change subject: mb/google/volteer/var/terrador: Disable SRCCLKREQ1# ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46592/2/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/terrador/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/46592/2/src/mainboard/google/voltee... PS2, Line 20: 0xFF PCIE_CLK_NOTUSED (baseboard should be updated too, sorry)
https://review.coreboot.org/c/coreboot/+/46592/2/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/todor/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/46592/2/src/mainboard/google/voltee... PS2, Line 20: 0xFF PCIE_CLK_NOTUSED (baseboard should be updated too, sorry)
Hello build bot (Jenkins), Caveh Jalali, Tim Wawrzynczak, Paul Fagerburg, Nick Vaccaro, Derek Huang,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46592
to look at the new patch set (#3).
Change subject: mb/google/volteer/var/terrador: Disable SRCCLKREQ1# ......................................................................
mb/google/volteer/var/terrador: Disable SRCCLKREQ1#
According to the schematic,SRCCLKREQ1# is not connected, so disable it for terrador and todor.
BUG=b:171278849 BRANCH=volteer TEST="emerge-volteer coreboot" compiles successfully.
Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com Change-Id: I5f7734d64390bfadbdb8d152261103adb8e75f40 --- M src/mainboard/google/volteer/variants/terrador/overridetree.cb M src/mainboard/google/volteer/variants/todor/overridetree.cb 2 files changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/46592/3
David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46592 )
Change subject: mb/google/volteer/var/terrador: Disable SRCCLKREQ1# ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46592/2/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/terrador/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/46592/2/src/mainboard/google/voltee... PS2, Line 20: 0xFF
PCIE_CLK_NOTUSED (baseboard should be updated too, sorry)
Done
https://review.coreboot.org/c/coreboot/+/46592/2/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/todor/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/46592/2/src/mainboard/google/voltee... PS2, Line 20: 0xFF
PCIE_CLK_NOTUSED (baseboard should be updated too, sorry)
Done
Sheng-Liang Pan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46592 )
Change subject: mb/google/volteer/var/terrador: Disable SRCCLKREQ1# ......................................................................
Patch Set 3: Code-Review+1
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46592 )
Change subject: mb/google/volteer/var/terrador: Disable SRCCLKREQ1# ......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/46592/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46592/3//COMMIT_MSG@9 PS3, Line 9: According to the schematic,SRCCLKREQ1# is not connected, : so disable it for terrador and todor. : reflow to 72 chars wide
Hello build bot (Jenkins), Caveh Jalali, Tim Wawrzynczak, Paul Fagerburg, Nick Vaccaro, Derek Huang, Sheng-Liang Pan,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46592
to look at the new patch set (#4).
Change subject: mb/google/volteer/var/terrador: Disable SRCCLKREQ1# ......................................................................
mb/google/volteer/var/terrador: Disable SRCCLKREQ1#
According to the schematic, SRCCLKREQ1# is not connected, so disable it for terrador and todor.
BUG=b:171278849 BRANCH=volteer TEST="emerge-volteer coreboot" compiles successfully.
Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com Change-Id: I5f7734d64390bfadbdb8d152261103adb8e75f40 --- M src/mainboard/google/volteer/variants/terrador/overridetree.cb M src/mainboard/google/volteer/variants/todor/overridetree.cb 2 files changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/46592/4
David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46592 )
Change subject: mb/google/volteer/var/terrador: Disable SRCCLKREQ1# ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46592/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46592/3//COMMIT_MSG@9 PS3, Line 9: According to the schematic,SRCCLKREQ1# is not connected, : so disable it for terrador and todor. :
reflow to 72 chars wide
Done
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46592 )
Change subject: mb/google/volteer/var/terrador: Disable SRCCLKREQ1# ......................................................................
mb/google/volteer/var/terrador: Disable SRCCLKREQ1#
According to the schematic, SRCCLKREQ1# is not connected, so disable it for terrador and todor.
BUG=b:171278849 BRANCH=volteer TEST="emerge-volteer coreboot" compiles successfully.
Signed-off-by: David Wu david_wu@quanta.corp-partner.google.com Change-Id: I5f7734d64390bfadbdb8d152261103adb8e75f40 Reviewed-on: https://review.coreboot.org/c/coreboot/+/46592 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Sheng-Liang Pan sheng-liang.pan@quanta.corp-partner.google.com Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/volteer/variants/terrador/overridetree.cb M src/mainboard/google/volteer/variants/todor/overridetree.cb 2 files changed, 6 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Sheng-Liang Pan: Looks good to me, but someone else must approve Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/google/volteer/variants/terrador/overridetree.cb b/src/mainboard/google/volteer/variants/terrador/overridetree.cb index 001d5f6..ae26e79 100644 --- a/src/mainboard/google/volteer/variants/terrador/overridetree.cb +++ b/src/mainboard/google/volteer/variants/terrador/overridetree.cb @@ -16,6 +16,9 @@
register "SaGv" = "SaGv_Disabled"
+ # Disable SRCCLKREQ1# + register "PcieClkSrcUsage[1]" = "PCIE_CLK_NOTUSED" + device domain 0 on device ref dptf on chip drivers/intel/dptf diff --git a/src/mainboard/google/volteer/variants/todor/overridetree.cb b/src/mainboard/google/volteer/variants/todor/overridetree.cb index 001d5f6..ae26e79 100644 --- a/src/mainboard/google/volteer/variants/todor/overridetree.cb +++ b/src/mainboard/google/volteer/variants/todor/overridetree.cb @@ -16,6 +16,9 @@
register "SaGv" = "SaGv_Disabled"
+ # Disable SRCCLKREQ1# + register "PcieClkSrcUsage[1]" = "PCIE_CLK_NOTUSED" + device domain 0 on device ref dptf on chip drivers/intel/dptf
-
David Wu (Code Review) -
Patrick Georgi (Code Review)
-
Paul Fagerburg (Code Review)
-
Paul Menzel (Code Review)
-
Sheng-Liang Pan (Code Review)
-
Tim Wawrzynczak (Code Review)