Attention is currently required from: Paul Menzel, Julius Werner, Yu-Ping Wu. Ravi Kumar Bokka has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63026 )
Change subject: soc/qualcomm/common: verify size of memchipinfo structure ......................................................................
Patch Set 4:
(8 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63026/comment/df6fcb9e_e0df7310 PS4, Line 8:
This should really say "Fix bugs introduced with CB:59195", because that's mostly what this is about […]
Commit message updated
File src/commonlib/bsd/include/commonlib/bsd/mem_chip_info.h:
PS3:
This file is not qualcomm code, so please add mem_chip_info_size() in a separate patch.
hi yu-ping, I have updated commit message with: src/commonlib/bsd: and this changes are created in separate commit id.
File src/soc/qualcomm/common/qclib.c:
https://review.coreboot.org/c/coreboot/+/63026/comment/c76c33eb_597dbed1 PS3, Line 43: if (mem_chip_info_size(mem_chip_addr) != 0)
I don't think we need to check this.
Ack
https://review.coreboot.org/c/coreboot/+/63026/comment/c8a5a394_1611af3c PS3, Line 45: mem_chip_info_size(mem_chip_addr));
Indentation
Ack
https://review.coreboot.org/c/coreboot/+/63026/comment/6ca3bdd0_d200e539 PS3, Line 180: NULL, 0, 0);
Can be moved into the previous line.
Ack
File src/soc/qualcomm/common/qclib.c:
https://review.coreboot.org/c/coreboot/+/63026/comment/861bed8e_59411992 PS4, Line 40: void *mem_region_base = NULL;
Please declare […]
Ack
https://review.coreboot.org/c/coreboot/+/63026/comment/47bc1a7d_b1f2cbb2 PS4, Line 44: mem_chip_info_size
Please align with "CBMEM_ID_MEM_CHIP_INFO" above. […]
Ack
https://review.coreboot.org/c/coreboot/+/63026/comment/51409ba6_301dcaa6 PS4, Line 177: /* Attempt to read MEM CHIP information */
I still asked for a better comment on this on the other patch. Maybe […]
Ack
-
Ravi Kumar Bokka (Code Review)