Attention is currently required from: Felix Held.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81338?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: vc/amd/opensil/genoa_poc/mpio: add ENGINE_ prefix to mpio_type values
......................................................................
Patch Set 2:
(1 comment)
File src/vendorcode/amd/opensil/genoa_poc/mpio/chip.h:
https://review.coreboot.org/c/coreboot/+/81338/comment/d5073b3f_b953dc7e :
PS2, Line 20: ENGINE_PCIE
These are getting renamed away from "engine" internally. Can we use "MUX_TYPE_[xyz]" instead?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81338?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I229a3402c36941ee5347e3704fcf8d8a1bbc78a6
Gerrit-Change-Number: 81338
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 19 Mar 2024 15:16:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment