Hello Edward O'Callaghan,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/37696
to review the following change.
Change subject: mainboard/google/puff: Toggle on DqPinsInterleaved ......................................................................
mainboard/google/puff: Toggle on DqPinsInterleaved
BUG=b:146172098 TEST=none
Change-Id: Ib2da3baace9255ef25c0f03390a064fd77ef9ae5 Signed-off-by: Edward O'Callaghan quasisec@google.com --- M src/mainboard/google/hatch/romstage_spd_smbus.c 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/37696/1
diff --git a/src/mainboard/google/hatch/romstage_spd_smbus.c b/src/mainboard/google/hatch/romstage_spd_smbus.c index 74d59a5..4a93a36 100644 --- a/src/mainboard/google/hatch/romstage_spd_smbus.c +++ b/src/mainboard/google/hatch/romstage_spd_smbus.c @@ -45,6 +45,7 @@
/* set to 2 VREF_CA goes to CH_A and VREF_DQ_B goes to CH_B. */ memcfg.vref_ca_config = 2; + memcfg.DqPinsInterleaved = 1;
cannonlake_memcfg_init(&memupd->FspmConfig, &memcfg); }
Hello Edward O'Callaghan, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37696
to look at the new patch set (#2).
Change subject: mainboard/google/puff: Toggle on DqPinsInterleaved ......................................................................
mainboard/google/puff: Toggle on DqPinsInterleaved
BRANCH=none BUG=b:146172098 TEST=./util/abuild/abuild -p none -t google/hatch -x -a
Change-Id: Ib2da3baace9255ef25c0f03390a064fd77ef9ae5 Signed-off-by: Edward O'Callaghan quasisec@google.com --- M src/mainboard/google/hatch/romstage_spd_smbus.c 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/37696/2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37696 )
Change subject: mainboard/google/puff: Toggle on DqPinsInterleaved ......................................................................
Patch Set 2: Code-Review+1
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37696 )
Change subject: mainboard/google/puff: Toggle on DqPinsInterleaved ......................................................................
Patch Set 2: Code-Review+2
Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37696 )
Change subject: mainboard/google/puff: Toggle on DqPinsInterleaved ......................................................................
Patch Set 2: Code-Review+1