HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33903
Change subject: mainboard/{avalue,roda}: remove stdlib.h when unused ......................................................................
mainboard/{avalue,roda}: remove stdlib.h when unused
Change-Id: Iad616e98feaebc6d5ec058fbf438ac2002a6b934 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/avalue/eax-785e/get_bus_conf.c M src/mainboard/roda/rk9/mainboard.c 2 files changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/33903/1
diff --git a/src/mainboard/avalue/eax-785e/get_bus_conf.c b/src/mainboard/avalue/eax-785e/get_bus_conf.c index 6b5ae68..7aca540 100644 --- a/src/mainboard/avalue/eax-785e/get_bus_conf.c +++ b/src/mainboard/avalue/eax-785e/get_bus_conf.c @@ -15,7 +15,6 @@
#include <device/pci.h> #include <stdint.h> -#include <stdlib.h> #include <cpu/amd/multicore.h> #include <cpu/amd/amdfam10_sysconf.h>
diff --git a/src/mainboard/roda/rk9/mainboard.c b/src/mainboard/roda/rk9/mainboard.c index 3f72398..6057901 100644 --- a/src/mainboard/roda/rk9/mainboard.c +++ b/src/mainboard/roda/rk9/mainboard.c @@ -14,7 +14,6 @@ */
#include <stdint.h> -#include <stdlib.h> #include <arch/io.h> #include <device/device.h> #include <drivers/intel/gma/int15.h>
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33903
to look at the new patch set (#2).
Change subject: mb/roda/rk9: Remove unused include <stdlib.h> ......................................................................
mb/roda/rk9: Remove unused include <stdlib.h>
Change-Id: Iad616e98feaebc6d5ec058fbf438ac2002a6b934 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/roda/rk9/mainboard.c 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/33903/2
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/33903 )
Change subject: mb/roda/rk9: Remove unused include <stdlib.h> ......................................................................
Abandoned
see 32023
HAOUAS Elyes has restored this change. ( https://review.coreboot.org/c/coreboot/+/33903 )
Change subject: mb/roda/rk9: Remove unused include <stdlib.h> ......................................................................
Restored
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33903
to look at the new patch set (#3).
Change subject: mb/{cavium,opencellular,roda,scaleway,ti}: Remove unused <stdlib.h> ......................................................................
mb/{cavium,opencellular,roda,scaleway,ti}: Remove unused <stdlib.h>
Change-Id: Iad616e98feaebc6d5ec058fbf438ac2002a6b934 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/cavium/cn8100_sff_evb/romstage.c M src/mainboard/opencellular/elgon/romstage.c M src/mainboard/roda/rk886ex/m3885.c M src/mainboard/roda/rk9/mainboard.c M src/mainboard/scaleway/tagada/bmcinfo.c M src/mainboard/ti/beaglebone/leds.c 6 files changed, 0 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/33903/3
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33903 )
Change subject: mb/{cavium,opencellular,roda,scaleway,ti}: Remove unused <stdlib.h> ......................................................................
Patch Set 7: Code-Review+2
Kyösti Mälkki has submitted this change. ( https://review.coreboot.org/c/coreboot/+/33903 )
Change subject: mb/{cavium,opencellular,roda,scaleway,ti}: Remove unused <stdlib.h> ......................................................................
mb/{cavium,opencellular,roda,scaleway,ti}: Remove unused <stdlib.h>
Change-Id: Iad616e98feaebc6d5ec058fbf438ac2002a6b934 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/33903 Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/cavium/cn8100_sff_evb/romstage.c M src/mainboard/opencellular/elgon/romstage.c M src/mainboard/roda/rk886ex/m3885.c M src/mainboard/roda/rk9/mainboard.c M src/mainboard/scaleway/tagada/bmcinfo.c M src/mainboard/ti/beaglebone/leds.c 6 files changed, 0 insertions(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved
diff --git a/src/mainboard/cavium/cn8100_sff_evb/romstage.c b/src/mainboard/cavium/cn8100_sff_evb/romstage.c index b60b9cd..81a4100 100644 --- a/src/mainboard/cavium/cn8100_sff_evb/romstage.c +++ b/src/mainboard/cavium/cn8100_sff_evb/romstage.c @@ -18,7 +18,6 @@ #include <soc/sdram.h> #include <soc/timer.h> #include <soc/mmu.h> -#include <stdlib.h> #include <libbdk-hal/bdk-config.h>
extern const struct bdk_devicetree_key_value devtree[]; diff --git a/src/mainboard/opencellular/elgon/romstage.c b/src/mainboard/opencellular/elgon/romstage.c index 94c09ec..d907351 100644 --- a/src/mainboard/opencellular/elgon/romstage.c +++ b/src/mainboard/opencellular/elgon/romstage.c @@ -19,7 +19,6 @@ #include <soc/sdram.h> #include <soc/timer.h> #include <soc/mmu.h> -#include <stdlib.h> #include <console/console.h> #include <program_loading.h> #include <libbdk-hal/bdk-config.h> diff --git a/src/mainboard/roda/rk886ex/m3885.c b/src/mainboard/roda/rk886ex/m3885.c index 60a4f48..d4e90b8 100644 --- a/src/mainboard/roda/rk886ex/m3885.c +++ b/src/mainboard/roda/rk886ex/m3885.c @@ -15,7 +15,6 @@ */
#include <types.h> -#include <stdlib.h> #include <console/console.h> #include <arch/io.h> #include <delay.h> diff --git a/src/mainboard/roda/rk9/mainboard.c b/src/mainboard/roda/rk9/mainboard.c index 3f72398..6057901 100644 --- a/src/mainboard/roda/rk9/mainboard.c +++ b/src/mainboard/roda/rk9/mainboard.c @@ -14,7 +14,6 @@ */
#include <stdint.h> -#include <stdlib.h> #include <arch/io.h> #include <device/device.h> #include <drivers/intel/gma/int15.h> diff --git a/src/mainboard/scaleway/tagada/bmcinfo.c b/src/mainboard/scaleway/tagada/bmcinfo.c index 93b4539..61dac15 100644 --- a/src/mainboard/scaleway/tagada/bmcinfo.c +++ b/src/mainboard/scaleway/tagada/bmcinfo.c @@ -15,7 +15,6 @@ */
#include <stdint.h> -#include <stdlib.h> #include <console/console.h> #include <console/uart.h>
diff --git a/src/mainboard/ti/beaglebone/leds.c b/src/mainboard/ti/beaglebone/leds.c index a4889b9..dd1471d 100644 --- a/src/mainboard/ti/beaglebone/leds.c +++ b/src/mainboard/ti/beaglebone/leds.c @@ -14,7 +14,6 @@
#include <assert.h> #include <cpu/ti/am335x/gpio.h> -#include <stdlib.h>
#include "leds.h"