Change in coreboot[master]: soc/intel/common/acpi: fix Windows crash on S0ix-enabled boards
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47138 )
Change subject: soc/intel/common/acpi: fix Windows crash on S0ix-enabled boards ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/47138/1/src/soc/intel/common/acpi/l... File src/soc/intel/common/acpi/lpit.asl:
https://review.coreboot.org/c/coreboot/+/47138/1/src/soc/intel/common/acpi/l... PS1, Line 37: Return(Package(5) {0, Ones, Ones, Ones, Ones})
This looks very odd. […]
Yes, not working.
https://review.coreboot.org/c/coreboot/+/47138/1/src/soc/intel/common/acpi/l... PS1, Line 26: This function
What function?
function 1; I moved that, thus must be corrected
https://review.coreboot.org/c/coreboot/+/47138/1/src/soc/intel/common/acpi/l... PS1, Line 26: debugging
Why would there be constraints for debugging?
The constraints are not there for debugging but the ACPI code returns the enabled/disabled states so they can be used for debugging
https://review.coreboot.org/c/coreboot/+/47138/1/src/soc/intel/common/acpi/l... PS1, Line 57: DEVY
Have you tried returning an empty package?
Yes and it does not work. Windows expects at least one constraint/device, as the commit message says
-
Michael Niewöhner (Code Review)