[XS] Change in coreboot[main]: mb/google/brox: Add 20K pulldown to GPP_D14 - coreboot-gerrit

29 Apr 2024


      Attention is currently required from: Nick Vaccaro, Shelley Chen.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82096?usp=email )
Change subject: mb/google/brox: Add 20K pulldown to GPP_D14
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/mainboard/google/brox/variants/baseboard/brox/gpio.c:
https://review.coreboot.org/c/coreboot/+/82096/comment/9bcad3ba_2859f47a :
PS1, Line 169: NONE)
...
Eric says that the RX is driven by the board already so isn't floating.
Acknowledged
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/82096?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4e19e98fa31022ece66a47402a2a4461b430ef70
Gerrit-Change-Number: 82096
Gerrit-PatchSet: 1
Gerrit-Owner: Shelley Chen shchen@google.com
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Shelley Chen shchen@google.com
Gerrit-Attention: Nick Vaccaro nvaccaro@google.com
Gerrit-Comment-Date: Mon, 29 Apr 2024 16:10:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Shelley Chen shchen@google.com
Comment-In-Reply-To: Karthik Ramasubramanian kramasub@google.com
Gerrit-MessageType: comment