[M] Change in coreboot[master]: soc/intel/xeon_sp: Read ioapic configuration from hardware
Attention is currently required from: Jonathan Zhang, Johnny Lin, Christian Walter, Kyösti Mälkki, Tim Chu.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70265 )
Change subject: soc/intel/xeon_sp: Read ioapic configuration from hardware ......................................................................
Patch Set 6:
(1 comment)
File src/soc/intel/xeon_sp/acpi.c:
https://review.coreboot.org/c/coreboot/+/70265/comment/18fe9918_3794b08e PS6, Line 100: xeonsp_ioapic_bases[index++] = hob->PlatformData.IIO_resource[0].StackRes[0].IoApicBase;
I think this is still weird if we enter the for-loop below
xeons_ioapic_bases[0] = hob->... IIO_res[0].SR[0].IoApicBase xeons_ioapic_bases[1] = hob->... IIO_res[0].SR[0].IoApicBase + 0x1000
Well newer Xeon_sp hardware has only one ioapic, which is why I handled the first entry differently. I guess I could add that one in the loop and return early if needed.
-
Arthur Heymans (Code Review)