Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35107 )
Change subject: build system: add kconfig/toada to tools list ......................................................................
build system: add kconfig/toada to tools list
Without this, we're lacking a serialization point in abuild when doing parallel builds. This manifests in parallel attempts to write the toada binary, which fails.
Change-Id: Id6ebbb3750284225670608e4927d80c4eea96afb Signed-off-by: Patrick Georgi pgeorgi@google.com --- M Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/35107/1
diff --git a/Makefile.inc b/Makefile.inc index ffb22d3..e560338 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -646,7 +646,7 @@ include util/crossgcc/Makefile.inc
.PHONY: tools -tools: $(objutil)/kconfig/conf $(CBFSTOOL) $(objutil)/cbfstool/cbfs-compression-tool $(FMAPTOOL) $(RMODTOOL) $(IFWITOOL) $(objutil)/nvramtool/nvramtool $(ROMCC_BIN) $(objutil)/sconfig/sconfig $(IFDTOOL) $(CBOOTIMAGE) $(AMDFWTOOL) $(AMDCOMPRESS) $(FUTILITY) $(BINCFG) $(IFITTOOL) +tools: $(objutil)/kconfig/conf $(objutil)/kconfig/toada $(CBFSTOOL) $(objutil)/cbfstool/cbfs-compression-tool $(FMAPTOOL) $(RMODTOOL) $(IFWITOOL) $(objutil)/nvramtool/nvramtool $(ROMCC_BIN) $(objutil)/sconfig/sconfig $(IFDTOOL) $(CBOOTIMAGE) $(AMDFWTOOL) $(AMDCOMPRESS) $(FUTILITY) $(BINCFG) $(IFITTOOL)
########################################################################### # Common recipes for all stages
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35107 )
Change subject: build system: add kconfig/toada to tools list ......................................................................
Patch Set 1:
Martin, I believe master will break due to this issue (see https://qa.coreboot.org/job/coreboot/11966/console). The slight differences in build tree handling from CB:35099 exposed this issue.
It's late here and I might be gone soon until next morning CEST, so please consider merging before the 24h deadline if you agree with my assessment.
David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35107 )
Change subject: build system: add kconfig/toada to tools list ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/35107 )
Change subject: build system: add kconfig/toada to tools list ......................................................................
build system: add kconfig/toada to tools list
Without this, we're lacking a serialization point in abuild when doing parallel builds. This manifests in parallel attempts to write the toada binary, which fails.
Change-Id: Id6ebbb3750284225670608e4927d80c4eea96afb Signed-off-by: Patrick Georgi pgeorgi@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35107 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: David Hendricks david.hendricks@gmail.com --- M Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified David Hendricks: Looks good to me, approved
diff --git a/Makefile.inc b/Makefile.inc index ffb22d3..e560338 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -646,7 +646,7 @@ include util/crossgcc/Makefile.inc
.PHONY: tools -tools: $(objutil)/kconfig/conf $(CBFSTOOL) $(objutil)/cbfstool/cbfs-compression-tool $(FMAPTOOL) $(RMODTOOL) $(IFWITOOL) $(objutil)/nvramtool/nvramtool $(ROMCC_BIN) $(objutil)/sconfig/sconfig $(IFDTOOL) $(CBOOTIMAGE) $(AMDFWTOOL) $(AMDCOMPRESS) $(FUTILITY) $(BINCFG) $(IFITTOOL) +tools: $(objutil)/kconfig/conf $(objutil)/kconfig/toada $(CBFSTOOL) $(objutil)/cbfstool/cbfs-compression-tool $(FMAPTOOL) $(RMODTOOL) $(IFWITOOL) $(objutil)/nvramtool/nvramtool $(ROMCC_BIN) $(objutil)/sconfig/sconfig $(IFDTOOL) $(CBOOTIMAGE) $(AMDFWTOOL) $(AMDCOMPRESS) $(FUTILITY) $(BINCFG) $(IFITTOOL)
########################################################################### # Common recipes for all stages
-
David Hendricks (Code Review) -
Patrick Georgi (Code Review)