Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Paul Menzel, Shou-Chieh Hsu, Subrata Banik.
Leo Chou has posted comments on this change by Leo Chou. ( https://review.coreboot.org/c/coreboot/+/82689?usp=email )
Change subject: mb/google/nissa/var/pujjoga: Tune SX9324 registers setting
......................................................................
Patch Set 5:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82689/comment/47f993ae_fe9e5b1c?usp... :
PS3, Line 7: Tune SX9324 register
Tune for what goal?
Tune the P sensor register setting for function work.
https://review.coreboot.org/c/coreboot/+/82689/comment/4c9de730_2a7ac61d?usp... :
PS3, Line 7: register
register*s*?
Done
https://review.coreboot.org/c/coreboot/+/82689/comment/a28b76f9_f7be0d0c?usp... :
PS3, Line 9: Update SX9324 register settings
`select DRIVERS_I2C_SX9324` suggests, it wasn’t used before. […]
Done
https://review.coreboot.org/c/coreboot/+/82689/comment/8fd10902_1a4ef1e7?usp... :
PS3, Line 12: =Check i2c register settings on Pujjoga
How?
use i2cdump -y -f 13 0x28 to check
https://review.coreboot.org/c/coreboot/+/82689/comment/c3583f0d_0d665114?usp... :
PS3, Line 13: confirm P sensor function can work
Did it work before this commit?
no, the P sensor is not workong before this commit.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82689?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I205c1f5228d792afc763a06f74a8744918e2da75
Gerrit-Change-Number: 82689
Gerrit-PatchSet: 5
Gerrit-Owner: Leo Chou
leo.chou@lcfc.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jerry2 Huang
jerry2.huang@lcfc.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Roger Wang
roger2.wang@lcfc.corp-partner.google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Comment-Date: Thu, 30 May 2024 06:38:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org