Jonathan Zhang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44281 )
Change subject: mb/ocp/deltalake: enable VT-d ......................................................................
mb/ocp/deltalake: enable VT-d
Update devicetree.cb to configure VT-d to be enabled.
TESTED=booted on DeltaLake config A server, and verify DMAR table.
Signed-off-by: Jonathan Zhang jonzhang@fb.com Change-Id: I7d76cd9d50d3e69a4919de281f11d30851bffa3f --- M src/mainboard/ocp/deltalake/devicetree.cb 1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/44281/1
diff --git a/src/mainboard/ocp/deltalake/devicetree.cb b/src/mainboard/ocp/deltalake/devicetree.cb index f77a214..1773f9f 100644 --- a/src/mainboard/ocp/deltalake/devicetree.cb +++ b/src/mainboard/ocp/deltalake/devicetree.cb @@ -33,8 +33,9 @@ # configure PSTATE_REQ_RATIO for MSR_IA32_PERF_CTRL register "pstate_req_ratio" = "0xa"
- register "coherency_support" = "0" - register "ats_support" = "0" + # configure VT-d + register "vtd_support" = "1" + register "x2apic" = "1"
register "gen1_dec" = "0x00fc0601" # BIC in-band update support register "gen2_dec" = "0x000c0ca1" # IPMI KCS
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44281 )
Change subject: mb/ocp/deltalake: enable VT-d ......................................................................
Patch Set 1: Code-Review+1
Hello build bot (Jenkins), Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44281
to look at the new patch set (#4).
Change subject: mb/ocp/deltalake: enable VT-d ......................................................................
mb/ocp/deltalake: enable VT-d
Update devicetree.cb to configure VT-d to be enabled.
TESTED=booted on DeltaLake config A server, and verify DMAR table.
Signed-off-by: Jonathan Zhang jonzhang@fb.com Change-Id: I7d76cd9d50d3e69a4919de281f11d30851bffa3f --- M src/mainboard/ocp/deltalake/devicetree.cb 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/44281/4
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44281 )
Change subject: mb/ocp/deltalake: enable VT-d ......................................................................
Patch Set 4: Code-Review+2
Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44281 )
Change subject: mb/ocp/deltalake: enable VT-d ......................................................................
Patch Set 4: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44281 )
Change subject: mb/ocp/deltalake: enable VT-d ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44281/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44281/4//COMMIT_MSG@9 PS4, Line 9: Update devicetree.cb to configure VT-d to be enabled. Why is x2apic needed?
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44281 )
Change subject: mb/ocp/deltalake: enable VT-d ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44281/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44281/4//COMMIT_MSG@9 PS4, Line 9: Update devicetree.cb to configure VT-d to be enabled.
Why is x2apic needed?
x2apic helps with interrupt distribution in virtualized environments. When VT-d is enabled, we need x2apic to be enabled as well (through FSP-M).
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44281 )
Change subject: mb/ocp/deltalake: enable VT-d ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44281/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44281/4//COMMIT_MSG@9 PS4, Line 9: Update devicetree.cb to configure VT-d to be enabled.
x2apic helps with interrupt distribution in virtualized environments. […]
Ack
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44281 )
Change subject: mb/ocp/deltalake: enable VT-d ......................................................................
mb/ocp/deltalake: enable VT-d
Update devicetree.cb to configure VT-d to be enabled.
TESTED=booted on DeltaLake config A server, and verify DMAR table.
Signed-off-by: Jonathan Zhang jonzhang@fb.com Change-Id: I7d76cd9d50d3e69a4919de281f11d30851bffa3f Reviewed-on: https://review.coreboot.org/c/coreboot/+/44281 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Maxim Polyakov max.senia.poliak@gmail.com --- M src/mainboard/ocp/deltalake/devicetree.cb 1 file changed, 4 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Maxim Polyakov: Looks good to me, approved
diff --git a/src/mainboard/ocp/deltalake/devicetree.cb b/src/mainboard/ocp/deltalake/devicetree.cb index 24a2850..1773f9f 100644 --- a/src/mainboard/ocp/deltalake/devicetree.cb +++ b/src/mainboard/ocp/deltalake/devicetree.cb @@ -33,6 +33,10 @@ # configure PSTATE_REQ_RATIO for MSR_IA32_PERF_CTRL register "pstate_req_ratio" = "0xa"
+ # configure VT-d + register "vtd_support" = "1" + register "x2apic" = "1" + register "gen1_dec" = "0x00fc0601" # BIC in-band update support register "gen2_dec" = "0x000c0ca1" # IPMI KCS
-
Angel Pons (Code Review) -
Jonathan Zhang (Code Review)
-
Maxim Polyakov (Code Review)
-
Paul Menzel (Code Review)