Aseda Aboagye has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34617 )
Change subject: mb/google/nocturne: Add MKBP events to SCI mask ......................................................................
mb/google/nocturne: Add MKBP events to SCI mask
Now that nocturne can wake from MKBP events, the MKBP host event ends up getting set once the AP boots to S0. Once, the AP is in S0, nothing clears that host event; instead the MKBP event is consumed via a GPIO notification. When the AP suspends, it immediately wakes up due to the pending host event. By adding the MKBP event to the SCI mask, the MKBP host event is cleared in S0 and the AP doesn't immediately wake from suspend.
BUG=chromium:984397 BRANCH=firmware-nocturne-10984.B TEST=flash nocturne, set MKBP event in suspend, verify DUT wakes up and does not immediately wake up on subsequent suspend.
Change-Id: Icfb6fc4d272ebb4ee82ab7b2d0d4f400cf8679cc Signed-off-by: Aseda Aboagye aaboagye@google.com --- M src/mainboard/google/poppy/variants/nocturne/include/variant/ec.h 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/34617/1
diff --git a/src/mainboard/google/poppy/variants/nocturne/include/variant/ec.h b/src/mainboard/google/poppy/variants/nocturne/include/variant/ec.h index dfb0f74..92929b3 100644 --- a/src/mainboard/google/poppy/variants/nocturne/include/variant/ec.h +++ b/src/mainboard/google/poppy/variants/nocturne/include/variant/ec.h @@ -33,6 +33,7 @@ EC_HOST_EVENT_MASK(EC_HOST_EVENT_THERMAL_THRESHOLD) |\ EC_HOST_EVENT_MASK(EC_HOST_EVENT_THROTTLE_START) |\ EC_HOST_EVENT_MASK(EC_HOST_EVENT_THROTTLE_STOP) |\ + EC_HOST_EVENT_MASK(EC_HOST_EVENT_MKBP) |\ EC_HOST_EVENT_MASK(EC_HOST_EVENT_PD_MCU) |\ EC_HOST_EVENT_MASK(EC_HOST_EVENT_MODE_CHANGE))
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34617 )
Change subject: mb/google/nocturne: Add MKBP events to SCI mask ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34617/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34617/1//COMMIT_MSG@13 PS1, Line 13: By adding the MKBP event to the SCI mask, Wouldn't this cause MKBP events coming in via two paths and cause problems with the tight timestamps?
Aseda Aboagye has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34617 )
Change subject: mb/google/nocturne: Add MKBP events to SCI mask ......................................................................
Patch Set 1: Code-Review-1
Yeah... more debugging needed
Aseda Aboagye has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/34617 )
Change subject: mb/google/nocturne: Add MKBP events to SCI mask ......................................................................
Abandoned
this isn't needed
-
Aseda Aboagye (Code Review) -
Furquan Shaikh (Code Review)