Attention is currently required from: Tarun Tuli, Ofer Fried, Tim Wawrzynczak, Nick Vaccaro.
Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68917 )
Change subject: mb/google/brya/variants/volmar: Add firmware config field for FP_MCU
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68917/comment/0e7e7809_ed4b91ed
PS2, Line 10: FP_MCU_MASK
Should be "FPMCU_MASK"
fixed.
File src/mainboard/google/brya/variants/volmar/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/68917/comment/0c6ff70c_036f64e7
PS2, Line 23: option FPMCU_ENABLED 0
OK, I thought it might be for a reason like that, just wanted to make sure.
Yes. backward compatible! The volmar fw_config field bit10 is zero.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68917
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I867771904811459697056662d5e29c545a1a9474
Gerrit-Change-Number: 68917
Gerrit-PatchSet: 3
Gerrit-Owner: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Ofer Fried
oferfried@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paz Zcharya
pazz@google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Ofer Fried
oferfried@google.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Comment-Date: Wed, 02 Nov 2022 01:29:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Comment-In-Reply-To: Nick Vaccaro
nvaccaro@google.com
Gerrit-MessageType: comment