Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45826 )
Change subject: soc/intel/icl: enable common CPU code ......................................................................
Patch Set 11:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45826/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45826/5//COMMIT_MSG@13 PS5, Line 13: like done for SKL,ICL,... already.
This isn't quite clear, IMHO. "like done for [...]ICL"? but this is ICL. […]
well.... ENABLE_VMX is already hooked up since 2ee8fe0
https://review.coreboot.org/c/coreboot/+/45826/2/src/soc/intel/icelake/romst... File src/soc/intel/icelake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/45826/2/src/soc/intel/icelake/romst... PS2, Line 59: m_cfg->VmxEnable = CONFIG(ENABLE_VMX);
Yes exactly, unfortunately the first was wrong, because for some reason I saw a return where none is […]
Done
-
Michael Niewöhner (Code Review)