[S] Change in coreboot[main]: mb/google/nissa/var/rull: add ssd timeing and modify ssd GPIO pins of...

[Rui Zhou (Code Review)]

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik.

Rui Zhou has posted comments on this change by Rui Zhou. ( https://review.coreboot.org/c/coreboot/+/84997?usp=email )

Change subject: mb/google/nissa/var/rull: add ssd timeing and modify ssd GPIO pins of rtd3
......................................................................

Patch Set 13:

(3 comments)

Patchset:

PS8:
> why not split the change into 3 cls […]

Done

File src/mainboard/google/brya/variants/rull/gpio.c:

https://review.coreboot.org/c/coreboot/+/84997/comment/1d16f167_de80259a?usp... :
PS8, Line 32: 
            : 	/* D11 : EN_PP1800_WCAM_X ==> EN_PP3300_SSD_X */
            : 	PAD_CFG_GPO(GPP_D11, 1, DEEP),
> already done https://review.coreboot. […]

Done

https://review.coreboot.org/c/coreboot/+/84997/comment/59249c4d_23044ea6?usp... :
PS8, Line 36: 	PAD_CFG_GPO_LOCK(GPP_B4, 1, LOCK_CONFIG),
> note, this PIN is getting locked so, won't be able to alter the configuration from kernel if needed  […]

Done