Attention is currently required from: Kangheui Won, Paul Menzel, Tim Wawrzynczak, Tyler Wang, Nick Vaccaro.
Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63893 )
Change subject: mb/google/brya/var/craask: Disable LTE-related GPIOs based on fw_config
......................................................................
Patch Set 8:
(1 comment)
File src/mainboard/google/brya/variants/craask/fw_config.c:
https://review.coreboot.org/c/coreboot/+/63893/comment/fd88091d_5deeaca6
PS7, Line 23: if (!fw_config_probe(FW_CONFIG(DB_USB, DB_1C_LTE))) {
: printk(BIOS_DEBUG, "Disable LTE-related GPIO pins.\n");
: gpio_configure_pads(lte_disable_pads, ARRAY_SIZE(lte_disable_pads));
: }
:
This approach leavess a gpio interrupt line (GPP_H19) floating for a short time.
I think Nick's point is that there's a short time between configuring GPP_H19 as an interrupt pin in the baseboard gpio.c and disabling it in fw_config.c, during which it will be floating. Is that right? That's my bad for doing it this way on nivviks, and we should fix nivviks too.
What you've done in patchset 8 would work for now, but it will get messy if we need to handle more fw_configs. So I think we should do what Nick suggested. I'll upload a CL fixing this for nivviks, then you can update this to match.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63893
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I37719cee48370a04534067aa64a3aa77e453948a
Gerrit-Change-Number: 63893
Gerrit-PatchSet: 8
Gerrit-Owner: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Cathy Chen
cathy_chen@quanta.corp-partner.google.com
Gerrit-CC: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Comment-Date: Wed, 04 May 2022 00:06:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nick Vaccaro
nvaccaro@google.com
Gerrit-MessageType: comment