Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/86279?usp=email )
Change subject: drivers/intel/gma: Drop unused MAILBOXES_DESKTOP ......................................................................
drivers/intel/gma: Drop unused MAILBOXES_DESKTOP
MAILBOXES_DESKTOP is unused, and the IGD opregion spec makes no distinction in the mailboxes supported between desktop and mobile platforms. Rename MAILBOXES_MOBILE to IGD_MAILBOXES for consistency with other mailbox variables and clean up the comment.
Change-Id: Ia06fe75702887aa6953bf17bd4bc14af4038bec5 Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/drivers/intel/gma/opregion.c M src/drivers/intel/gma/opregion.h 2 files changed, 3 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/86279/1
diff --git a/src/drivers/intel/gma/opregion.c b/src/drivers/intel/gma/opregion.c index 92665e0..4f5f802 100644 --- a/src/drivers/intel/gma/opregion.c +++ b/src/drivers/intel/gma/opregion.c @@ -367,8 +367,8 @@ /* 8kb */ opregion->header.size = sizeof(igd_opregion_t) / 1024;
- // FIXME We just assume we're mobile for now - opregion->header.mailboxes = MAILBOXES_MOBILE; + // Supported mailboxes + opregion->header.mailboxes = IGD_MAILBOXES;
// TODO Initialize Mailbox 1 opregion->mailbox1.clid = 1; diff --git a/src/drivers/intel/gma/opregion.h b/src/drivers/intel/gma/opregion.h index 2de9213..77fccf8 100644 --- a/src/drivers/intel/gma/opregion.h +++ b/src/drivers/intel/gma/opregion.h @@ -41,8 +41,7 @@ #define IGD_MBOX4 (1 << 3) #define IGD_MBOX5 (1 << 4)
-#define MAILBOXES_MOBILE (IGD_MBOX1 | IGD_MBOX3 | IGD_MBOX4 | IGD_MBOX5) -#define MAILBOXES_DESKTOP (IGD_MBOX2 | IGD_MBOX4) +#define IGD_MAILBOXES (IGD_MBOX1 | IGD_MBOX3 | IGD_MBOX4 | IGD_MBOX5)
#define SBIOS_VERSION_SIZE 32