Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/26720 )
Change subject: util/sconfig: Re-factor sconfig to not assume chip as device ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/26720/2/util/sconfig/sconfig.tab.c_shipped File util/sconfig/sconfig.tab.c_shipped:
https://review.coreboot.org/#/c/26720/2/util/sconfig/sconfig.tab.c_shipped@1... PS2, Line 112: USR_LOCAL_GOOGLE_HOME_FURQUAN_COREBOOT_ This needs to be fixed.
https://review.coreboot.org/#/c/26720/2/util/sconfig/sconfig.tab.h_shipped File util/sconfig/sconfig.tab.h_shipped:
https://review.coreboot.org/#/c/26720/2/util/sconfig/sconfig.tab.h_shipped@3... PS2, Line 33: YY_YY_USR_LOCAL_GOOGLE_HOME_FURQUAN_COREBOOT_UTIL_SCONFIG_SCONFIG_TAB_H_SHIPPED_INCLUDED this too.