Change in coreboot[master]: AGESA,binaryPI: Replace use of __PRE_RAM__ - coreboot-gerrit

19 Aug 2019


      Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34997 )
Change subject: AGESA,binaryPI: Replace use of __PRE_RAM__
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34997/1/src/southbridge/amd/cimx/sb... 
File src/southbridge/amd/cimx/sb800/fan.h:
https://review.coreboot.org/c/coreboot/+/34997/1/src/southbridge/amd/cimx/sb... 
PS1, Line 19: #include <device/device.h>
...
Was this intentional?
Two lines below want struct device, although anonymous.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/34997
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id878fd33ec3d2de640d9a488058a805be3ccd223
Gerrit-Change-Number: 34997
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: Piotr Król piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Comment-Date: Tue, 20 Aug 2019 02:08:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-MessageType: comment