Kevin Chiu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45061 )
Change subject: mb/google/zork: update TS power control for dirinboz ......................................................................
mb/google/zork: update TS power control for dirinboz
3.6 schematic will separate TS power from eDP PP3300 to AGPIO32 for power control.
BUG=b:161579679 BRANCH=master TEST=emerge-zork coreboot
Change-Id: Ieef67e1d04201c5d9e1dc625c519e6d0307c55f0 Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com --- M src/mainboard/google/zork/variants/dirinboz/overridetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/45061/1
diff --git a/src/mainboard/google/zork/variants/dirinboz/overridetree.cb b/src/mainboard/google/zork/variants/dirinboz/overridetree.cb index 0e35d99..05c5110 100644 --- a/src/mainboard/google/zork/variants/dirinboz/overridetree.cb +++ b/src/mainboard/google/zork/variants/dirinboz/overridetree.cb @@ -52,7 +52,7 @@ register "desc" = ""ELAN Touchscreen"" register "probed" = "1" register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(GPIO_12)" - register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_90)" + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_32)" register "enable_delay_ms" = "1" register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_140)" register "reset_delay_ms" = "20" @@ -67,7 +67,7 @@ register "generic.desc" = ""G2TOUCH Touchscreen"" register "generic.irq_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(GPIO_12)" register "generic.probed" = "1" - register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_90)" + register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_32)" register "generic.enable_delay_ms" = "1" register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_140)" register "generic.reset_delay_ms" = "50"
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45061 )
Change subject: mb/google/zork: update TS power control for dirinboz ......................................................................
Patch Set 1: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/45061/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45061/1//COMMIT_MSG@10 PS1, Line 10: for power control. It would be good to mention that the power control was incorrectly set as GPIO_90 instead of GPIO_32 for dirinboz.
https://review.coreboot.org/c/coreboot/+/45061/1//COMMIT_MSG@13 PS1, Line 13: master zork
Hello build bot (Jenkins), Furquan Shaikh, Martin Roth, Patrick Georgi, Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45061
to look at the new patch set (#2).
Change subject: mb/google/zork: update TS power control for dirinboz ......................................................................
mb/google/zork: update TS power control for dirinboz
3.6 schematic will separate TS power from eDP PP3300 to GPIO for power control and correct GPIO assignment from GPIO_90 to GPIO_32 instead.
BUG=b:161579679 BRANCH=zork TEST=emerge-zork coreboot
Change-Id: Ieef67e1d04201c5d9e1dc625c519e6d0307c55f0 Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com --- M src/mainboard/google/zork/variants/dirinboz/overridetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/45061/2
Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45061 )
Change subject: mb/google/zork: update TS power control for dirinboz ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45061/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45061/1//COMMIT_MSG@10 PS1, Line 10: for power control.
It would be good to mention that the power control was incorrectly set as GPIO_90 instead of GPIO_32 […]
Done
https://review.coreboot.org/c/coreboot/+/45061/1//COMMIT_MSG@13 PS1, Line 13: master
zork
Done
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45061 )
Change subject: mb/google/zork: update TS power control for dirinboz ......................................................................
Patch Set 2: Code-Review+2
Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45061 )
Change subject: mb/google/zork: update TS power control for dirinboz ......................................................................
mb/google/zork: update TS power control for dirinboz
3.6 schematic will separate TS power from eDP PP3300 to GPIO for power control and correct GPIO assignment from GPIO_90 to GPIO_32 instead.
BUG=b:161579679 BRANCH=zork TEST=emerge-zork coreboot
Change-Id: Ieef67e1d04201c5d9e1dc625c519e6d0307c55f0 Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/45061 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/zork/variants/dirinboz/overridetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/google/zork/variants/dirinboz/overridetree.cb b/src/mainboard/google/zork/variants/dirinboz/overridetree.cb index 0e35d99..05c5110 100644 --- a/src/mainboard/google/zork/variants/dirinboz/overridetree.cb +++ b/src/mainboard/google/zork/variants/dirinboz/overridetree.cb @@ -52,7 +52,7 @@ register "desc" = ""ELAN Touchscreen"" register "probed" = "1" register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(GPIO_12)" - register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_90)" + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_32)" register "enable_delay_ms" = "1" register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_140)" register "reset_delay_ms" = "20" @@ -67,7 +67,7 @@ register "generic.desc" = ""G2TOUCH Touchscreen"" register "generic.irq_gpio" = "ACPI_GPIO_IRQ_EDGE_LOW(GPIO_12)" register "generic.probed" = "1" - register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_90)" + register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_32)" register "generic.enable_delay_ms" = "1" register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_140)" register "generic.reset_delay_ms" = "50"
-
Furquan Shaikh (Code Review) -
Kevin Chiu (Code Review)