Attention is currently required from: Dolan Liu, Eric Lai, Jianeng Ceng, Subrata Banik.
Dolan Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81773?usp=email )
Change subject: drivers/i2c/rt5645: Add RT5645 amp driver ......................................................................
Patch Set 2: Code-Review+1
(4 comments)
File src/drivers/i2c/rt5645/rt5645.c:
https://review.coreboot.org/c/coreboot/+/81773/comment/ec60fe73_886fcb1c : PS2, Line 59: acpigen_write_name_string("_DDN", dev->chip_ops->name); better to use the `config->desc` if defined
https://review.coreboot.org/c/coreboot/+/81773/comment/95d787c8_f047d418 : PS2, Line 100: printk(BIOS_INFO, "%s: %s\n", path, dev->chip_ops->name); if chip_ops->name change to `&config->desc`, this should be changed to the same
https://review.coreboot.org/c/coreboot/+/81773/comment/79ae880c_22f2f097 : PS2, Line 110: snprintf(name, sizeof(name), "D%03.3X", dev->chip_ops->name); better to print `dev->path.i2c.device`
https://review.coreboot.org/c/coreboot/+/81773/comment/ffdb2505_f57b3054 : PS2, Line 112: //return RT5645_ACPI_NAME; remove this