Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31133 )
Change subject: soc/intel/cannonlake: Add SOC_INTEL_WHISKEYLAKE kconfig
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/31133/4/src/soc/intel/cannonlake/Kconfig
File src/soc/intel/cannonlake/Kconfig:
https://review.coreboot.org/#/c/31133/4/src/soc/intel/cannonlake/Kconfig@26
PS4, Line 26: SOC_INTEL_CANNONLAKE
I think putting it into OR statement would communicate the same, essentially all SOCs sharing the sa […]
yes, i think Intel marketing foils for CFL and WHL SoC also acknowledge that fact its build on CNP patch hence inheritance makes more sense to me rather OR'ing here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31133
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I66b63361841f5a16615ddce4225c4f6182eabdb3
Gerrit-Change-Number: 31133
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: PraveenX Hodagatta Pranesh
praveenx.hodagatta.pranesh@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 31 Jan 2019 06:14:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Aamir Bohra
aamir.bohra@intel.com
Gerrit-MessageType: comment