Change in coreboot[master]: util/lint: Accept "GPL-2.0 WITH Linux-syscall-note" licenses
Rajat Jain has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39887 )
Change subject: util/lint: Accept "GPL-2.0 WITH Linux-syscall-note" licenses ......................................................................
util/lint: Accept "GPL-2.0 WITH Linux-syscall-note" licenses
The Linux kernel UAPI header files are licensed under /* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
Allows files with this license to be included in coreboot. For more details about this particular license:
https://www.kernel.org/doc/html/v4.17/process/license-rules.html https://spdx.org/licenses/Linux-syscall-note.html
Change-Id: I4f0f8d36c637a66a6999a18321fdbc4c42d5751e Signed-off-by: Rajat Jain rajatja@google.com --- M util/lint/lint-000-license-headers 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/39887/1
diff --git a/util/lint/lint-000-license-headers b/util/lint/lint-000-license-headers index 1382d7f..d202cb7 100755 --- a/util/lint/lint-000-license-headers +++ b/util/lint/lint-000-license-headers @@ -105,6 +105,7 @@ check_for_license 'SPDX-License-Identifier: BSD-3-Clause' check_for_license 'SPDX-License-Identifier: GPL-2.0-only' check_for_license 'SPDX-License-Identifier: GPL-2.0-or-later' +check_for_license 'SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note' check_for_license 'SPDX-License-Identifier: GPL-3.0-only' check_for_license 'SPDX-License-Identifier: GPL-3.0-or-later' check_for_license 'SPDX-License-Identifier: ISC'
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39887 )
Change subject: util/lint: Accept "GPL-2.0 WITH Linux-syscall-note" licenses ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39887/1/util/lint/lint-000-license-... File util/lint/lint-000-license-headers:
https://review.coreboot.org/c/coreboot/+/39887/1/util/lint/lint-000-license-... PS1, Line 108: check_for_license 'SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note' Shouldn't it be GPL-2.0-only WITH Linux-syscall-note? I believe this syntax may be deprecated. (If Linux files are still using it, we'd have to decide whether we prefer taking them as is or fixing the license header for them.)
Rajat Jain has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39887 )
Change subject: util/lint: Accept "GPL-2.0 WITH Linux-syscall-note" licenses ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39887/1/util/lint/lint-000-license-... File util/lint/lint-000-license-headers:
https://review.coreboot.org/c/coreboot/+/39887/1/util/lint/lint-000-license-... PS1, Line 108: check_for_license 'SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note'
Shouldn't it be GPL-2.0-only WITH Linux-syscall-note? I believe this syntax may be deprecated. (If Linux files are still using it, we'd have to decide whether we prefer taking them as is or fixing the license header for them.)
I don't know much about licensing, can you point to some references that indicate that this is deprecated? There are 612 such files today in Linux with this license in include/uapi. So I'm not sure.
+dtor, would you be open to a linux patch changing the license on top of input-event-codes.h to "GPL-2.0-only WITH Linux-syscall-note"?
Dmitry Torokhov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39887 )
Change subject: util/lint: Accept "GPL-2.0 WITH Linux-syscall-note" licenses ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39887/1/util/lint/lint-000-license-... File util/lint/lint-000-license-headers:
https://review.coreboot.org/c/coreboot/+/39887/1/util/lint/lint-000-license-... PS1, Line 108: check_for_license 'SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note'
Shouldn't it be GPL-2.0-only WITH Linux-syscall-note? I believe this syntax may be deprecated. […]
I'm fine with updating to the new syntax. Send me a patch, CC Greg KH (and maybe Thomas Gleixner).
Rajat Jain has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39887 )
Change subject: util/lint: Accept "GPL-2.0 WITH Linux-syscall-note" licenses ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39887/1/util/lint/lint-000-license-... File util/lint/lint-000-license-headers:
https://review.coreboot.org/c/coreboot/+/39887/1/util/lint/lint-000-license-... PS1, Line 108: check_for_license 'SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note'
I'm fine with updating to the new syntax. Send me a patch, CC Greg KH (and maybe Thomas Gleixner).
Will do.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39887 )
Change subject: util/lint: Accept "GPL-2.0 WITH Linux-syscall-note" licenses ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39887/1/util/lint/lint-000-license-... File util/lint/lint-000-license-headers:
https://review.coreboot.org/c/coreboot/+/39887/1/util/lint/lint-000-license-... PS1, Line 108: check_for_license 'SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note'
can you point to some references that indicate that this is deprecated?
From https://spdx.org/licenses/
Release 3.0 replaced previous Identifiers for GNU licenses with more explicit Identifiers to reflect the "this version only" or "any later version" option specific to those licenses. As such, the previously used Identifiers for those licenses are deprecated as of v3.0.
You can see GPL-2.0 is in the deprecated list.
Rajat Jain has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39887 )
Change subject: util/lint: Accept "GPL-2.0 WITH Linux-syscall-note" licenses ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39887/1/util/lint/lint-000-license-... File util/lint/lint-000-license-headers:
https://review.coreboot.org/c/coreboot/+/39887/1/util/lint/lint-000-license-... PS1, Line 108: check_for_license 'SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note'
can you point to some references that indicate that this is deprecated? […]
Greg KH nack'ed the patch.
https://lkml.org/lkml/2020/3/28/35
So I guess we'll have to live with the current license.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39887 )
Change subject: util/lint: Accept "GPL-2.0 WITH Linux-syscall-note" licenses ......................................................................
Patch Set 2: Code-Review+1
Hello Shelley Chen, build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Dmitry Torokhov, Tim Wawrzynczak, Duncan Laurie, Dmitry Torokhov,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39887
to look at the new patch set (#3).
Change subject: util/lint: Accept "GPL-2.0-only WITH Linux-syscall-note" licenses ......................................................................
util/lint: Accept "GPL-2.0-only WITH Linux-syscall-note" licenses
The Linux kernel UAPI header files are licensed under /* SPDX-License-Identifier: GPL-2.0-only WITH Linux-syscall-note */
Allows files with this license to be included in coreboot. For more details about this particular license:
https://www.kernel.org/doc/html/v4.17/process/license-rules.html https://spdx.org/licenses/Linux-syscall-note.html
Change-Id: I4f0f8d36c637a66a6999a18321fdbc4c42d5751e Signed-off-by: Rajat Jain rajatja@google.com --- M util/lint/lint-000-license-headers 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/39887/3
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39887 )
Change subject: util/lint: Accept "GPL-2.0-only WITH Linux-syscall-note" licenses ......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/39887/1/util/lint/lint-000-license-... File util/lint/lint-000-license-headers:
https://review.coreboot.org/c/coreboot/+/39887/1/util/lint/lint-000-license-... PS1, Line 108: check_for_license 'SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note'
Greg KH nack'ed the patch. […]
To close the loop on this - I believe your change was accepted upstream: https://patchwork.kernel.org/patch/11464109/
Rajat Jain has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39887 )
Change subject: util/lint: Accept "GPL-2.0-only WITH Linux-syscall-note" licenses ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39887/1/util/lint/lint-000-license-... File util/lint/lint-000-license-headers:
https://review.coreboot.org/c/coreboot/+/39887/1/util/lint/lint-000-license-... PS1, Line 108: check_for_license 'SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note'
To close the loop on this - I believe your change was accepted upstream: https://patchwork.kernel. […]
Ack
Furquan Shaikh has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39887 )
Change subject: util/lint: Accept "GPL-2.0-only WITH Linux-syscall-note" licenses ......................................................................
util/lint: Accept "GPL-2.0-only WITH Linux-syscall-note" licenses
The Linux kernel UAPI header files are licensed under /* SPDX-License-Identifier: GPL-2.0-only WITH Linux-syscall-note */
Allows files with this license to be included in coreboot. For more details about this particular license:
https://www.kernel.org/doc/html/v4.17/process/license-rules.html https://spdx.org/licenses/Linux-syscall-note.html
Change-Id: I4f0f8d36c637a66a6999a18321fdbc4c42d5751e Signed-off-by: Rajat Jain rajatja@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/39887 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com --- M util/lint/lint-000-license-headers 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/util/lint/lint-000-license-headers b/util/lint/lint-000-license-headers index 1382d7f..c1110ec 100755 --- a/util/lint/lint-000-license-headers +++ b/util/lint/lint-000-license-headers @@ -105,6 +105,7 @@ check_for_license 'SPDX-License-Identifier: BSD-3-Clause' check_for_license 'SPDX-License-Identifier: GPL-2.0-only' check_for_license 'SPDX-License-Identifier: GPL-2.0-or-later' +check_for_license 'SPDX-License-Identifier: GPL-2.0-only WITH Linux-syscall-note' check_for_license 'SPDX-License-Identifier: GPL-3.0-only' check_for_license 'SPDX-License-Identifier: GPL-3.0-or-later' check_for_license 'SPDX-License-Identifier: ISC'
-
Dmitry Torokhov (Code Review) -
Furquan Shaikh (Code Review)
-
Julius Werner (Code Review)
-
Rajat Jain (Code Review)