Attention is currently required from: Karthik Ramasubramanian, Keith Short, Shelley Chen.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80308?usp=email )
Change subject: util/cbfstool: Fallback to linear search ......................................................................
Patch Set 1:
(1 comment)
File util/cbfstool/flashmap/fmap.c:
https://review.coreboot.org/c/coreboot/+/80308/comment/816d267c_14230a05 : PS1, Line 108: 16 I think if you want to allow FMAPs to be found at a smaller alignment it would make more sense to reduce this number here.
However, do we actually want that? This was set to 16 intentionally in CB:317321. I don't think there's a single authoritative "FMAP specification", but I feel like a completely misaligned FMAP would just be not valid. (Usually, we aim to intentionally make the FMAP alignment much larger to reduce lookup times.)
Do you have a real situation where an FMAP is aligned to less than 16 bytes? Why can't it be aligned better?
(Also, FWIW, cbfstool is only really meant to work on CBFS images, which an EC binary is not. If you're just looking for an FMAP parser, I'd suggest using `dump_fmap -h ec.bin` instead.)