[S] Change in coreboot[main]: nb/intel/sandybridge: Add CFR objects for existing options

[Matt DeVillier (Code Review)]

Attention is currently required from: Angel Pons, Intel coreboot Reviewers.

Matt DeVillier has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/87388?usp=email )

Change subject: nb/intel/sandybridge: Add CFR objects for existing options
......................................................................

Patch Set 1:

(4 comments)

File src/northbridge/intel/sandybridge/cfr.h:

https://review.coreboot.org/c/coreboot/+/87388/comment/1bdc8c43_16546b2a?usp... :
PS1, Line 7: #include <drivers/option/cfr_frontend.h>
> nit: shouldn't the include be within the cpp guard? (ifndef/define/endif)

yep, will fix

https://review.coreboot.org/c/coreboot/+/87388/comment/efcd1846_3aab9b65?usp... :
PS1, Line 17: 1282
> What's up with this number?

typo, will fix

https://review.coreboot.org/c/coreboot/+/87388/comment/06e390a2_69408d7f?usp... :
PS1, Line 20: /* Power state after power loss */
> Ahem, that's copy-pasta

not sure what you mean here

https://review.coreboot.org/c/coreboot/+/87388/comment/bca7bea9_629ce9bc?usp... :
PS1, Line 26: .values		= (const struct sm_enum_value[]) {
            : 				{ " 32MB", IGD_UMA_SIZE_32MB	},
            : 				{ " 64MB", IGD_UMA_SIZE_64MB	},
            : 				{ " 96MB", IGD_UMA_SIZE_96MB	},
            : 				{ "128MB", IGD_UMA_SIZE_1282MB	},
            : 				SM_ENUM_VALUE_END		},
> There's a lot more possible values than that, I think it can go up to 1 GiB as per some CMOS layouts […]

these are the values currently offered via Kconfig