Aaron Durbin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38612 )
Change subject: soc/amd/stoneyridge: use SMBus timeout in compliation unit ......................................................................
soc/amd/stoneyridge: use SMBus timeout in compliation unit
The timeout is fixed and only used in one place. Put the assumption in the compliation unit utilizing the defintion.
Change-Id: I7537549da90d0bc158e638c533e8e8b0f1e28a7d Signed-off-by: Aaron Durbin adurbin@chromium.org --- M src/soc/amd/stoneyridge/include/soc/smbus.h M src/soc/amd/stoneyridge/smbus.c 2 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/38612/1
diff --git a/src/soc/amd/stoneyridge/include/soc/smbus.h b/src/soc/amd/stoneyridge/include/soc/smbus.h index 4638fcd..ada7cfb 100644 --- a/src/soc/amd/stoneyridge/include/soc/smbus.h +++ b/src/soc/amd/stoneyridge/include/soc/smbus.h @@ -19,12 +19,6 @@ #include <stdint.h> #include <soc/iomap.h>
-/* - * Between 1-10 seconds, We should never timeout normally - * Longer than this is just painful when a timeout condition occurs. - */ -#define SMBUS_TIMEOUT (100 * 1000 * 10) - int do_smbus_read_byte(u32 mmio, u8 device, u8 address); int do_smbus_write_byte(u32 mmio, u8 device, u8 address, u8 val); int do_smbus_recv_byte(u32 mmio, u8 device); diff --git a/src/soc/amd/stoneyridge/smbus.c b/src/soc/amd/stoneyridge/smbus.c index 79f09d6..f5a9d60 100644 --- a/src/soc/amd/stoneyridge/smbus.c +++ b/src/soc/amd/stoneyridge/smbus.c @@ -19,6 +19,12 @@ #include <soc/smbus.h> #include <soc/southbridge.h>
+/* + * Between 1-10 seconds, We should never timeout normally + * Longer than this is just painful when a timeout condition occurs. + */ +#define SMBUS_TIMEOUT (100 * 1000 * 10) + static u8 controller_read8(u32 base, u8 reg) { switch (base) {
Aaron Durbin has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/38612 )
Change subject: soc/amd/stoneyridge: use SMBus timeout in compilation unit ......................................................................
soc/amd/stoneyridge: use SMBus timeout in compilation unit
The timeout is fixed and only used in one place. Put the assumption in the compliation unit utilizing the defintion.
Change-Id: I7537549da90d0bc158e638c533e8e8b0f1e28a7d Signed-off-by: Aaron Durbin adurbin@chromium.org --- M src/soc/amd/stoneyridge/include/soc/smbus.h M src/soc/amd/stoneyridge/smbus.c 2 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/38612/2
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38612 )
Change subject: soc/amd/stoneyridge: use SMBus timeout in compilation unit ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/38612/2/src/soc/amd/stoneyridge/smb... File src/soc/amd/stoneyridge/smbus.c:
https://review.coreboot.org/c/coreboot/+/38612/2/src/soc/amd/stoneyridge/smb... PS2, Line 69: } while (--loops); These need attention and conversion to stopwatch() at some later date.
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38612 )
Change subject: soc/amd/stoneyridge: use SMBus timeout in compilation unit ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38612/2/src/soc/amd/stoneyridge/smb... File src/soc/amd/stoneyridge/smbus.c:
https://review.coreboot.org/c/coreboot/+/38612/2/src/soc/amd/stoneyridge/smb... PS2, Line 69: } while (--loops);
These need attention and conversion to stopwatch() at some later date.
Ack
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38612 )
Change subject: soc/amd/stoneyridge: use SMBus timeout in compilation unit ......................................................................
Patch Set 3: Code-Review+2
Aaron Durbin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38612 )
Change subject: soc/amd/stoneyridge: use SMBus timeout in compilation unit ......................................................................
soc/amd/stoneyridge: use SMBus timeout in compilation unit
The timeout is fixed and only used in one place. Put the assumption in the compliation unit utilizing the defintion.
Change-Id: I7537549da90d0bc158e638c533e8e8b0f1e28a7d Signed-off-by: Aaron Durbin adurbin@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/38612 Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/amd/stoneyridge/include/soc/smbus.h M src/soc/amd/stoneyridge/smbus.c 2 files changed, 6 insertions(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved
diff --git a/src/soc/amd/stoneyridge/include/soc/smbus.h b/src/soc/amd/stoneyridge/include/soc/smbus.h index 4638fcd..ada7cfb 100644 --- a/src/soc/amd/stoneyridge/include/soc/smbus.h +++ b/src/soc/amd/stoneyridge/include/soc/smbus.h @@ -19,12 +19,6 @@ #include <stdint.h> #include <soc/iomap.h>
-/* - * Between 1-10 seconds, We should never timeout normally - * Longer than this is just painful when a timeout condition occurs. - */ -#define SMBUS_TIMEOUT (100 * 1000 * 10) - int do_smbus_read_byte(u32 mmio, u8 device, u8 address); int do_smbus_write_byte(u32 mmio, u8 device, u8 address, u8 val); int do_smbus_recv_byte(u32 mmio, u8 device); diff --git a/src/soc/amd/stoneyridge/smbus.c b/src/soc/amd/stoneyridge/smbus.c index 79f09d6..f5a9d60 100644 --- a/src/soc/amd/stoneyridge/smbus.c +++ b/src/soc/amd/stoneyridge/smbus.c @@ -19,6 +19,12 @@ #include <soc/smbus.h> #include <soc/southbridge.h>
+/* + * Between 1-10 seconds, We should never timeout normally + * Longer than this is just painful when a timeout condition occurs. + */ +#define SMBUS_TIMEOUT (100 * 1000 * 10) + static u8 controller_read8(u32 base, u8 reg) { switch (base) {
-
Aaron Durbin (Code Review) -
Angel Pons (Code Review)
-
Kyösti Mälkki (Code Review)