Attention is currently required from: Zheng Bao. Hello Zheng Bao,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/59010
to review the following change.
Change subject: majolica: Add spaces for EC firmware to enable Type-C adaptor ......................................................................
majolica: Add spaces for EC firmware to enable Type-C adaptor
The next 20kByte after 128k of stock BIOS is optional to enable the type-C DC adaptor. If you use the 148kByte, don't forget to fill the 0x20000-0x21000 which is ROMSIG to all FFs or 0s.
The old EC_majolica.bin can still be used without building error and problems, except the type-C DC adaptor can not be used.
Change-Id: Ib311e46c8765f17a1af5bc0b00c387268f4cfae5 Signed-off-by: Zheng Bao fishbaozi@gmail.com --- M src/mainboard/amd/majolica/Kconfig M src/mainboard/amd/majolica/board.fmd M src/mainboard/amd/majolica/chromeos.fmd 3 files changed, 5 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/59010/1
diff --git a/src/mainboard/amd/majolica/Kconfig b/src/mainboard/amd/majolica/Kconfig index cba0a0f..1646855 100644 --- a/src/mainboard/amd/majolica/Kconfig +++ b/src/mainboard/amd/majolica/Kconfig @@ -38,7 +38,9 @@ default "3rdparty/blobs/mainboard/amd/majolica/EC_majolica.bin" help The EC firmware blob is usually the first 128kByte of the stock - firmware image. + firmware image. The next 20kByte is optional to enable the type-C + DC adaptor. If you use the 148kByte, don't forget to fill the + 0x20000-0x21000 which is ROMSIG to all FFs or 0s.
config VBOOT select VBOOT_NO_BOARD_SUPPORT diff --git a/src/mainboard/amd/majolica/board.fmd b/src/mainboard/amd/majolica/board.fmd index 442d80f..8ae6b47 100644 --- a/src/mainboard/amd/majolica/board.fmd +++ b/src/mainboard/amd/majolica/board.fmd @@ -1,6 +1,6 @@ FLASH@0xFF000000 16M { BIOS { - EC 128K + EC 148K RW_MRC_CACHE 64K FMAP 4K COREBOOT(CBFS) diff --git a/src/mainboard/amd/majolica/chromeos.fmd b/src/mainboard/amd/majolica/chromeos.fmd index bb21767..779eecd 100644 --- a/src/mainboard/amd/majolica/chromeos.fmd +++ b/src/mainboard/amd/majolica/chromeos.fmd @@ -1,6 +1,6 @@ FLASH@0xFF000000 16M { SI_BIOS { - EC 128K + EC 148K RW_MRC_CACHE(PRESERVE) 64K RW_SECTION_A 3M { VBLOCK_A 8K