Attention is currently required from: Philipp Hug, weidongwd, ron minnich.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74799 )
Change subject: ACPI,SMBIOS : Provide ACPI and SMBIOS supports for RISC-V
......................................................................
Patch Set 1:
(2 comments)
File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/74799/comment/31d2bbbf_defc8450
PS1, Line 859: #depends on ARCH_X86
`depends on ARCH_X86 || ARCH_RISCV` ?
File src/arch/riscv/smbios.c:
PS1:
Much of this looks common to x86 & RISC-V, seems like it would be simpler to have a common file and two architecture-specific ones?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74799
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8c47d22e8e383e8c90387caab82796b6b4d5eff5
Gerrit-Change-Number: 74799
Gerrit-PatchSet: 1
Gerrit-Owner: weidongwd
weidong.wd@bytedance.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Philipp Hug
philipp@hug.cx
Gerrit-Attention: weidongwd
weidong.wd@bytedance.com
Gerrit-Attention: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Mon, 01 May 2023 14:23:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment