Attention is currently required from: Jakub Czapiga, Julius Werner, Martin L Roth.
Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81081?usp=email )
Change subject: lib/device_tree: Add some FDT helper functions
......................................................................
Patch Set 7:
(3 comments)
Patchset:
PS6:
I tested it on my machine and it fails too. […]
Weird that I never hit this issue. Thanks for testing and review.
File src/lib/device_tree.c:
https://review.coreboot.org/c/coreboot/+/81081/comment/7cc51a2b_6904c17e :
PS6, Line 67: size = fdt_next_node_name(blob, offset, &name);
`int size = ...`. Let's not multiply code without need.
Done
https://review.coreboot.org/c/coreboot/+/81081/comment/07b716bd_04f718ec :
PS6, Line 272: node_offset = results[(*count_results)++] = off; // save occurrence
`count_results` is left uninitialized. More info in another comment.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81081?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2fb1d93c5b3e1cb2f7d9584db52bbce3767b63d8
Gerrit-Change-Number: 81081
Gerrit-PatchSet: 7
Gerrit-Owner: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Fri, 08 Mar 2024 11:14:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jakub Czapiga
czapiga@google.com
Comment-In-Reply-To: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-MessageType: comment