Attention is currently required from: Angel Pons.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64008 )
Change subject: mb/google/brya/acpi: Add support for NBCI _DSM subfunction
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/brya/acpi/nbci.asl:
https://review.coreboot.org/c/coreboot/+/64008/comment/04364453_ca095c6e
PS1, Line 25: (0 << 10) | /* No 3D Hotkeys */
Yes
Yes, just being explicit about the fields (bits that are not called out are reserved)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/64008
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I19eb9417923d297a084d6f5329682e91cd506a9e
Gerrit-Change-Number: 64008
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Tue, 03 May 2022 15:16:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment