Change in coreboot[master]: drivers/intel/gma/acpi: Bail out on empty display list

[Nico Huber (Code Review)]

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39978 )

Change subject: drivers/intel/gma/acpi: Bail out on empty display list
......................................................................

drivers/intel/gma/acpi: Bail out on empty display list

Whether the GMA is used depends on the mainboard, so we shouldn't rely
on the presence of the static ACPI code around `GFX0`.

Change-Id: I4d20b459b8361e43435b535b2b395f51ce1704e6
Signed-off-by: Nico Huber 
---
M src/drivers/intel/gma/acpi.c
1 file changed, 3 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/39978/1

diff --git a/src/drivers/intel/gma/acpi.c b/src/drivers/intel/gma/acpi.c
index c0eef88..5a10ab4 100644
--- a/src/drivers/intel/gma/acpi.c
+++ b/src/drivers/intel/gma/acpi.c
@@ -13,6 +13,9 @@
    const char *names[] = { "UNK", "VGA", "TV", "DVI", "LCD" };
    int counters[ARRAY_SIZE(names)] = { 0 };

+	if (!conf->ndid)
+		return;
+
    acpigen_write_scope("\_SB.PCI0.GFX0");

/*

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39978 )

Change subject: drivers/intel/gma/acpi: Bail out on empty display list
......................................................................

Patch Set 1: Code-Review+2

[Matt DeVillier (Code Review)]

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39978 )

Change subject: drivers/intel/gma/acpi: Bail out on empty display list
......................................................................

Patch Set 1: Code-Review+2

[Matt DeVillier (Code Review)]

Matt DeVillier has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39978 )

Change subject: drivers/intel/gma/acpi: Bail out on empty display list
......................................................................

drivers/intel/gma/acpi: Bail out on empty display list

Whether the GMA is used depends on the mainboard, so we shouldn't rely
on the presence of the static ACPI code around `GFX0`.

Change-Id: I4d20b459b8361e43435b535b2b395f51ce1704e6
Signed-off-by: Nico Huber 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/39978
Reviewed-by: Angel Pons 
Reviewed-by: Matt DeVillier 
Tested-by: build bot (Jenkins) 
---
M src/drivers/intel/gma/acpi.c
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Matt DeVillier: Looks good to me, approved
  Angel Pons: Looks good to me, approved

diff --git a/src/drivers/intel/gma/acpi.c b/src/drivers/intel/gma/acpi.c
index c0eef88..5a10ab4 100644
--- a/src/drivers/intel/gma/acpi.c
+++ b/src/drivers/intel/gma/acpi.c
@@ -13,6 +13,9 @@
    const char *names[] = { "UNK", "VGA", "TV", "DVI", "LCD" };
    int counters[ARRAY_SIZE(names)] = { 0 };

+	if (!conf->ndid)
+		return;
+
    acpigen_write_scope("\_SB.PCI0.GFX0");

/*