Attention is currently required from: Eran Mitrani, Eric Lai, Jakub Czapiga, Kapil Porwal, Sumeet R Pawnikar, Tarun.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78180?usp=email )
Change subject: mb/google/rex/var/rex0: update dptf thermal settings ......................................................................
Patch Set 2:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/78180/comment/b6d3049d_097bd19e : PS2, Line 7: update dptf thermal settings Maybe more specific:
Update DPTF thermal settings to start fan earlier
https://review.coreboot.org/c/coreboot/+/78180/comment/6f136570_257bc3c8 : PS2, Line 9: During internal testing observed Maybe: Internal testing showed, …
https://review.coreboot.org/c/coreboot/+/78180/comment/459d91b7_d68523f9 : PS2, Line 10: While this even fan does not start : to control the temperature. Maybe: In this situation, the fan does not even start to lower the temperature.
https://review.coreboot.org/c/coreboot/+/78180/comment/0515fa36_05fedaf3 : PS2, Line 12: high too high
https://review.coreboot.org/c/coreboot/+/78180/comment/a5ac46b0_84f0eabb : PS2, Line 13: With updated new settings Please document, where the new settings came from. At what temperature does the fan start?
https://review.coreboot.org/c/coreboot/+/78180/comment/3bda829a_1ffbdcac : PS2, Line 13: start fan early for TSR0 and TSR1 : sensors to prevent high CPU temperature Maybe: … the fan starts early for TSR0 and TSR1 so the temperature stays below X °C.
-
Paul Menzel (Code Review)