Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35728 )
Change subject: intel/quark: Drop xx_DEV_FUNC ......................................................................
intel/quark: Drop xx_DEV_FUNC
Change-Id: Ice1062d10b793dcbeb5b2ce9e2788fd3b6b6250b Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/soc/intel/quark/include/soc/pci_devs.h 1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/35728/1
diff --git a/src/soc/intel/quark/include/soc/pci_devs.h b/src/soc/intel/quark/include/soc/pci_devs.h index 1e17402..a24f28f 100644 --- a/src/soc/intel/quark/include/soc/pci_devs.h +++ b/src/soc/intel/quark/include/soc/pci_devs.h @@ -50,25 +50,21 @@ #define SIO2_DEV 0x15 #define I2CGPIO_DEV SIO2_DEV #define I2CGPIO_FUNC 2 -#define I2CGPIO_DEV_FUNC PCI_DEVFN(I2CGPIO_DEV, I2CGPIO_FUNC) #define I2CGPIO_BDF PCI_DEV(PCI_BUS_NUMBER_QNC, I2CGPIO_DEV, I2CGPIO_FUNC)
/* PCIe Ports */ #define PCIE_DEV 0x17 #define PCIE_PORT0_DEV PCIE_DEV #define PCIE_PORT0_FUNC 0 -#define PCIE_PORT0_DEV_FUNC PCI_DEVFN(PCIE_DEV, PCIE_PORT0_FUNC) #define PCIE_PORT0_BDF PCI_DEV(PCI_BUS_NUMBER_QNC, PCIE_DEV, PCIE_PORT0_FUNC)
#define PCIE_PORT1_DEV PCIE_DEV #define PCIE_PORT1_FUNC 1 -#define PCIE_PORT1_DEV_FUNC PCI_DEVFN(PCIE_DEV, PCIE_PORT1_FUNC) #define PCIE_PORT1_BDF PCI_DEV(PCI_BUS_NUMBER_QNC, PCIE_DEV, PCIE_PORT1_FUNC)
/* Platform Controller Unit */ #define LPC_DEV PCI_DEVICE_NUMBER_QNC_LPC #define LPC_FUNC PCI_FUNCTION_NUMBER_QNC_LPC -#define LPC_DEV_FUNC PCI_DEVFN(LPC_DEV, LPC_FUNC) #define LPC_BDF PCI_DEV(PCI_BUS_NUMBER_QNC, LPC_DEV, LPC_FUNC)
#endif /* _QUARK_PCI_DEVS_H_ */
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35728 )
Change subject: intel/quark: Drop xx_DEV_FUNC ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35728/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35728/1//COMMIT_MSG@8 PS1, Line 8: Could you please add the reasoning? I assume they aren't used based on no compilation error. It would be good to capture the reasoning in the commit description.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35728 )
Change subject: intel/quark: Drop xx_DEV_FUNC ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35728/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35728/1//COMMIT_MSG@8 PS1, Line 8:
Could you please add the reasoning? I assume they aren't used based on no compilation error. […]
Done
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35728 )
Change subject: intel/quark: Drop xx_DEV_FUNC ......................................................................
Patch Set 2: Code-Review+2
Kyösti Mälkki has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35728 )
Change subject: intel/quark: Drop xx_DEV_FUNC ......................................................................
intel/quark: Drop xx_DEV_FUNC
Intel adopted xx_DEVFN_xx naming for macros expanding to PCI_DEVFN() starting with apollolake. The ones named xx_DEV_FUNC are being renamed, or dropped, if they were generally not used at all for a platform.
Change-Id: Ice1062d10b793dcbeb5b2ce9e2788fd3b6b6250b Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35728 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Aaron Durbin adurbin@chromium.org --- M src/soc/intel/quark/include/soc/pci_devs.h 1 file changed, 0 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved
diff --git a/src/soc/intel/quark/include/soc/pci_devs.h b/src/soc/intel/quark/include/soc/pci_devs.h index 1e17402..a24f28f 100644 --- a/src/soc/intel/quark/include/soc/pci_devs.h +++ b/src/soc/intel/quark/include/soc/pci_devs.h @@ -50,25 +50,21 @@ #define SIO2_DEV 0x15 #define I2CGPIO_DEV SIO2_DEV #define I2CGPIO_FUNC 2 -#define I2CGPIO_DEV_FUNC PCI_DEVFN(I2CGPIO_DEV, I2CGPIO_FUNC) #define I2CGPIO_BDF PCI_DEV(PCI_BUS_NUMBER_QNC, I2CGPIO_DEV, I2CGPIO_FUNC)
/* PCIe Ports */ #define PCIE_DEV 0x17 #define PCIE_PORT0_DEV PCIE_DEV #define PCIE_PORT0_FUNC 0 -#define PCIE_PORT0_DEV_FUNC PCI_DEVFN(PCIE_DEV, PCIE_PORT0_FUNC) #define PCIE_PORT0_BDF PCI_DEV(PCI_BUS_NUMBER_QNC, PCIE_DEV, PCIE_PORT0_FUNC)
#define PCIE_PORT1_DEV PCIE_DEV #define PCIE_PORT1_FUNC 1 -#define PCIE_PORT1_DEV_FUNC PCI_DEVFN(PCIE_DEV, PCIE_PORT1_FUNC) #define PCIE_PORT1_BDF PCI_DEV(PCI_BUS_NUMBER_QNC, PCIE_DEV, PCIE_PORT1_FUNC)
/* Platform Controller Unit */ #define LPC_DEV PCI_DEVICE_NUMBER_QNC_LPC #define LPC_FUNC PCI_FUNCTION_NUMBER_QNC_LPC -#define LPC_DEV_FUNC PCI_DEVFN(LPC_DEV, LPC_FUNC) #define LPC_BDF PCI_DEV(PCI_BUS_NUMBER_QNC, LPC_DEV, LPC_FUNC)
#endif /* _QUARK_PCI_DEVS_H_ */
-
Aaron Durbin (Code Review) -
Kyösti Mälkki (Code Review)