Name of user not set #1002476 has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34630 )
Change subject: mb/intel/minnowmax: Adding config for FSP_PACKAGE_DEFAULT ......................................................................
mb/intel/minnowmax: Adding config for FSP_PACKAGE_DEFAULT
Config VGA_BIOS is using FSP_PACKAGE_DEFAULT, so added config for the same. Also updated the default path for config FSP_FILE according to the current coreboot directory structure.
Change-Id: Ifb1a92287ad5beea6559db0cd4cf66eeb0f46f95 Signed-off-by: Himanshu Sahdev Coreboot@hcl.com --- M src/mainboard/intel/minnowmax/Kconfig 1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/34630/1
diff --git a/src/mainboard/intel/minnowmax/Kconfig b/src/mainboard/intel/minnowmax/Kconfig index ca24c92..0e3de50 100644 --- a/src/mainboard/intel/minnowmax/Kconfig +++ b/src/mainboard/intel/minnowmax/Kconfig @@ -37,7 +37,7 @@
config FSP_FILE string - default "../intel/fsp/baytrail/BAYTRAIL_FSP.fd" + default "3rdparty/fsp/BayTrailFspBinPkg/FspBin/BAYTRAIL_FSP.fd"
config CBFS_SIZE hex @@ -57,6 +57,10 @@ bool default n
+config FSP_PACKAGE_DEFAULT + bool "Configure defaults for the Intel FSP package" + default n + config VGA_BIOS bool default y if FSP_PACKAGE_DEFAULT
Hello Huang Jin, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34630
to look at the new patch set (#2).
Change subject: mb/intel/minnowmax: Adding config for FSP_PACKAGE_DEFAULT ......................................................................
mb/intel/minnowmax: Adding config for FSP_PACKAGE_DEFAULT
Config VGA_BIOS is using FSP_PACKAGE_DEFAULT, so added config for the same. Also updated the default path for config FSP_FILE according to the current coreboot directory structure.
Change-Id: Ifb1a92287ad5beea6559db0cd4cf66eeb0f46f95 Signed-off-by: Himanshu Sahdev coreboot@hcl.com --- M src/mainboard/intel/minnowmax/Kconfig 1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/34630/2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34630 )
Change subject: mb/intel/minnowmax: Adding config for FSP_PACKAGE_DEFAULT ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/34630/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34630/2//COMMIT_MSG@7 PS2, Line 7: Adding Imperative mood: Add
https://review.coreboot.org/c/coreboot/+/34630/2//COMMIT_MSG@9 PS2, Line 9: added add
https://review.coreboot.org/c/coreboot/+/34630/2//COMMIT_MSG@10 PS2, Line 10: updated update
https://review.coreboot.org/c/coreboot/+/34630/2//COMMIT_MSG@10 PS2, Line 10: Also updated the default path for config FSP_FILE according to the current coreboot directory structure. Please adhere to the line length limit, which is 75 characters.
Hello Huang Jin, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34630
to look at the new patch set (#3).
Change subject: mb/intel/minnowmax: Add config for FSP_PACKAGE_DEFAULT ......................................................................
mb/intel/minnowmax: Add config for FSP_PACKAGE_DEFAULT
Config VGA_BIOS is using FSP_PACKAGE_DEFAULT, so add config for the same. Update default path for config FSP_FILE as per current directory structure.
Change-Id: Ifb1a92287ad5beea6559db0cd4cf66eeb0f46f95 Signed-off-by: Himanshu Sahdev coreboot@hcl.com --- M src/mainboard/intel/minnowmax/Kconfig 1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/34630/3
Name of user not set #1002476 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34630 )
Change subject: mb/intel/minnowmax: Add config for FSP_PACKAGE_DEFAULT ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34630/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34630/2//COMMIT_MSG@7 PS2, Line 7: Adding
Imperative mood: Add
Done
Name of user not set #1002476 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34630 )
Change subject: mb/intel/minnowmax: Add config for FSP_PACKAGE_DEFAULT ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34630/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34630/2//COMMIT_MSG@9 PS2, Line 9: added
add
Done
Name of user not set #1002476 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34630 )
Change subject: mb/intel/minnowmax: Add config for FSP_PACKAGE_DEFAULT ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34630/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34630/2//COMMIT_MSG@10 PS2, Line 10: updated
update
Done
https://review.coreboot.org/c/coreboot/+/34630/2//COMMIT_MSG@10 PS2, Line 10: Also updated the default path for config FSP_FILE according to the current coreboot directory structure.
Please adhere to the line length limit, which is 75 characters.
Done
Hello Huang Jin, build bot (Jenkins), Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34630
to look at the new patch set (#4).
Change subject: mb/intel/minnowmax: Add config for FSP_PACKAGE_DEFAULT ......................................................................
mb/intel/minnowmax: Add config for FSP_PACKAGE_DEFAULT
Config VGA_BIOS is using FSP_PACKAGE_DEFAULT, so add config for the same. Update default path for config FSP_FILE as per current directory structure.
Change-Id: Ifb1a92287ad5beea6559db0cd4cf66eeb0f46f95 Signed-off-by: Himanshu Sahdev himanshusah@hcl.com --- M src/mainboard/intel/minnowmax/Kconfig 1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/34630/4
Hello Huang Jin, build bot (Jenkins), Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34630
to look at the new patch set (#6).
Change subject: mb/intel/minnowmax: Add config for FSP_PACKAGE_DEFAULT ......................................................................
mb/intel/minnowmax: Add config for FSP_PACKAGE_DEFAULT
Config VGA_BIOS is using FSP_PACKAGE_DEFAULT, so add config for the same. Select HAVE_FSP_BIN to add microcode header files when FSP_PACKAGE_DEFAULT.
Change-Id: Ifb1a92287ad5beea6559db0cd4cf66eeb0f46f95 Signed-off-by: Himanshu Sahdev himanshusah@hcl.com --- M src/mainboard/intel/minnowmax/Kconfig 1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/34630/6
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34630 )
Change subject: mb/intel/minnowmax: Add config for FSP_PACKAGE_DEFAULT ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34630/7/src/mainboard/intel/minnowm... File src/mainboard/intel/minnowmax/Kconfig:
https://review.coreboot.org/c/coreboot/+/34630/7/src/mainboard/intel/minnowm... PS7, Line 62: Configure defaults for the Intel FSP package This does not seem to match the description of what it does. All it does is setting CONFIG_VGA_BIOS=y by default and always CONFIG_HAVE_FSP_BIN=y.
I don't really see a point in this symbol. Maybe drop it from all mainboard Kconfig files?
Name of user not set #1002476 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34630 )
Change subject: mb/intel/minnowmax: Add config for FSP_PACKAGE_DEFAULT ......................................................................
Patch Set 7:
(1 comment)
Lets have some more eyes on this.
https://review.coreboot.org/c/coreboot/+/34630/7/src/mainboard/intel/minnowm... File src/mainboard/intel/minnowmax/Kconfig:
https://review.coreboot.org/c/coreboot/+/34630/7/src/mainboard/intel/minnowm... PS7, Line 62: Configure defaults for the Intel FSP package
This does not seem to match the description of what it does. […]
Yeah, it seems not directly, but indirectly, it matches the description of what it does.
Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/34630?usp=email )
Change subject: mb/intel/minnowmax: Add config for FSP_PACKAGE_DEFAULT ......................................................................
Abandoned
This patch has not been touched in over 12 months. Anyone who wants to take over work on this patch, please feel free to restore it and do any work needed to get it merged. If you create a new patch based on this work, please credit the original author.
-
Arthur Heymans (Code Review) -
Martin L Roth (Code Review)
-
Name of user not set (Code Review)
-
Paul Menzel (Code Review)