CoolStar has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/77528?usp=email )
Change subject: soc/intel: Add ACPI device for GNA ......................................................................
soc/intel: Add ACPI device for GNA
Add ACPI device definition and names for the GNA Scoring Accelerator on tigerlake and alderlake. Enable for volteer and brya baseboards
Allows Intel PEP to setup power management without BSOD'ing in Windows
Test: build/boot google/brya (banshee) and google/nissa (craaskvin) to Win11 and install driver for GNA Scoring Accelerator
Change-Id: I3398eefb80e4407594883dd39128cd7885105ac3 Signed-off-by: CoolStar coolstarorganization@gmail.com --- M src/mainboard/google/brya/dsdt.asl M src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb M src/mainboard/google/brya/variants/baseboard/nissa/devicetree.cb M src/mainboard/google/volteer/dsdt.asl M src/soc/intel/alderlake/chip.c A src/soc/intel/common/block/acpi/acpi/gna.asl M src/soc/intel/tigerlake/chip.c 7 files changed, 14 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/77528/1
diff --git a/src/mainboard/google/brya/dsdt.asl b/src/mainboard/google/brya/dsdt.asl index 7a730b74..de2def1 100644 --- a/src/mainboard/google/brya/dsdt.asl +++ b/src/mainboard/google/brya/dsdt.asl @@ -26,6 +26,7 @@ #include <soc/intel/common/block/acpi/acpi/northbridge.asl> #include <soc/intel/alderlake/acpi/southbridge.asl> #include <soc/intel/alderlake/acpi/tcss.asl> + #include <soc/intel/common/block/acpi/acpi/gna.asl> } }
diff --git a/src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb b/src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb index d48462c..3ae3862 100644 --- a/src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb +++ b/src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb @@ -158,6 +158,7 @@ device ref tbt_pcie_rp0 on end device ref tbt_pcie_rp1 on end device ref tbt_pcie_rp2 on end + device ref gna on end device ref tcss_xhci on end device ref tcss_dma0 on end device ref tcss_dma1 on end diff --git a/src/mainboard/google/brya/variants/baseboard/nissa/devicetree.cb b/src/mainboard/google/brya/variants/baseboard/nissa/devicetree.cb index ad5b1f8..2a9e39e 100644 --- a/src/mainboard/google/brya/variants/baseboard/nissa/devicetree.cb +++ b/src/mainboard/google/brya/variants/baseboard/nissa/devicetree.cb @@ -153,6 +153,7 @@ device domain 0 on device ref igpu on end device ref dtt on end + device ref gna on end device ref tcss_xhci on end device ref xhci on end device ref shared_sram on end diff --git a/src/mainboard/google/volteer/dsdt.asl b/src/mainboard/google/volteer/dsdt.asl index eeaf613..c200294 100644 --- a/src/mainboard/google/volteer/dsdt.asl +++ b/src/mainboard/google/volteer/dsdt.asl @@ -28,6 +28,7 @@ #include <soc/intel/common/block/acpi/acpi/northbridge.asl> #include <soc/intel/tigerlake/acpi/southbridge.asl> #include <soc/intel/tigerlake/acpi/tcss.asl> + #include <soc/intel/common/block/acpi/acpi/gna.asl> #include <drivers/intel/gma/acpi/default_brightness_levels.asl> #if CONFIG(VARIANT_HAS_MIPI_CAMERA) #include <soc/intel/common/block/acpi/acpi/ipu.asl> diff --git a/src/soc/intel/alderlake/chip.c b/src/soc/intel/alderlake/chip.c index 7f24032..8b32b96 100644 --- a/src/soc/intel/alderlake/chip.c +++ b/src/soc/intel/alderlake/chip.c @@ -94,6 +94,7 @@ case SA_DEVFN_TBT2: return "TRP2"; case SA_DEVFN_TBT3: return "TRP3"; case SA_DEVFN_IPU: return "IPU0"; + case SA_DEVFN_GNA: return "GNA"; case SA_DEVFN_DPTF: return "TCPU"; case PCH_DEVFN_ISH: return "ISHB"; case PCH_DEVFN_XHCI: return "XHCI"; diff --git a/src/soc/intel/common/block/acpi/acpi/gna.asl b/src/soc/intel/common/block/acpi/acpi/gna.asl new file mode 100644 index 0000000..2191846 --- /dev/null +++ b/src/soc/intel/common/block/acpi/acpi/gna.asl @@ -0,0 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +/* GNA Scoring Accelerator - Device 08, Function 0 */ +Device (GNA) +{ + Name (_ADR, 0x00080000) + Name (_DDN, "GNA Scoring Accelerator") +} \ No newline at end of file diff --git a/src/soc/intel/tigerlake/chip.c b/src/soc/intel/tigerlake/chip.c index 242ec98..15281c8 100644 --- a/src/soc/intel/tigerlake/chip.c +++ b/src/soc/intel/tigerlake/chip.c @@ -83,6 +83,7 @@ case SA_DEVFN_TBT2: return "TRP2"; case SA_DEVFN_TBT3: return "TRP3"; case SA_DEVFN_IPU: return "IPU0"; + case SA_DEVFN_GNA: return "GNA"; case PCH_DEVFN_ISH: return "ISHB"; case PCH_DEVFN_XHCI: return "XHCI"; case PCH_DEVFN_I2C0: return "I2C0";
-
CoolStar (Code Review)