Change in coreboot[master]: util/inteltool: Add support for Tiger Lake chips detection and GPIOs
Attention is currently required from: Felix Singer, Wonkyu Kim, Michał Żygowski, Ravishankar Sarawadi, Stefan Reinauer. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56171 )
Change subject: util/inteltool: Add support for Tiger Lake chips detection and GPIOs ......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
meh, confirmed. We've seen that on other platforms already, but TGL seems to be special.... […]
verified by checking register dump:
``` com0 root@debian:~# memtool md -l 0xfd6e0700+0x500 # GPP_B fd6e0700: 44000700 0003c018 00000100 00000000 ...D............ fd6e0710: 44000700 0003c019 00000100 00000000 ...D............ fd6e0720: 44000102 0000301a 00000000 00000000 ...D.0.......... fd6e0730: 80800102 0000001b 00000000 00000000 ................ fd6e0740: 44000300 0000001c 00000000 00000000 ...D............ fd6e0750: 44000300 0000001d 00000000 00000000 ...D............ fd6e0760: 44000300 0000001e 00000000 00000000 ...D............ fd6e0770: 44000300 0000001f 00000000 00000000 ...D............ fd6e0780: 44000300 00000020 00000000 00000000 ...D ........... fd6e0790: 44000300 00000021 00000000 00000000 ...D!........... fd6e07a0: 44000300 00000022 00000000 00000000 ...D"........... fd6e07b0: 04000702 00000023 00000000 00000000 ....#........... fd6e07c0: 44000700 0003c024 00000000 00000000 ...D$........... fd6e07d0: 44000700 0003c025 00000000 00000000 ...D%........... fd6e07e0: 44000200 0003c026 00000000 00000000 ...D&........... fd6e07f0: 44000300 00000027 00000000 00000000 ...D'........... fd6e0800: 44000300 00000028 00000000 00000000 ...D(........... fd6e0810: 44000300 00000029 00000000 00000000 ...D)........... fd6e0820: 44000300 0000002a 00000100 00000000 ...D*........... fd6e0830: 44000300 0000002b 00000000 00000000 ...D+........... fd6e0840: 44000300 0000002c 00000000 00000000 ...D,........... fd6e0850: 44000300 0000002d 00000000 00000000 ...D-........... fd6e0860: 44000300 0000002e 00000000 00000000 ...D............ fd6e0870: 44000200 0000002f 00000000 00000000 ...D/........... # GSPI0_CLK_LOOPBK fd6e0880: 40000700 00000000 00000000 00000000 ...@............ # GSPI1_CLK_LOOPBK fd6e0890: 40000700 00000000 00000000 00000000 ...@............ ^^ # GPP_T fd6e08a0: 44000300 00000030 00000000 00000000 ...D0........... fd6e08b0: 44000300 00000031 00000000 00000000 ...D1........... fd6e08c0: 44000300 00000032 00000000 00000000 ...D2........... fd6e08d0: 44000300 00000033 00000000 00000000 ...D3........... fd6e08e0: 44000300 00000034 00000000 00000000 ...D4........... fd6e08f0: 44000300 00000035 00000000 00000000 ...D5........... fd6e0900: 44000300 00000036 00000000 00000000 ...D6........... fd6e0910: 44000300 00000037 00000000 00000000 ...D7........... fd6e0920: 44000300 00000038 00000000 00000000 ...D8........... fd6e0930: 44000300 00000039 00000000 00000000 ...D9........... fd6e0940: 44000300 0000003a 00000000 00000000 ...D:........... fd6e0950: 44000300 0000003b 00000000 00000000 ...D;........... fd6e0960: 44000300 0000003c 00000000 00000000 ...D<........... fd6e0970: 44000300 0000003d 00000000 00000000 ...D=........... fd6e0980: 44000300 0000003e 00000000 00000000 ...D>........... fd6e0990: 44000300 0000003f 00000000 00000000 ...D?........... # GPP_A fd6e09a0: 44000700 0003f040 00000100 00000000 ...D@........... fd6e09b0: 44000702 0003f041 00000100 00000000 ...DA........... fd6e09c0: 44000700 0003f042 00000100 00000000 ...DB........... fd6e09d0: 44000700 0003f043 00000100 00000000 ...DC........... fd6e09e0: 44000700 0003f044 00000100 00000000 ...DD........... fd6e09f0: 44000700 0003d045 00000100 00000000 ...DE........... fd6e0a00: 44000700 0003c046 00000100 00000000 ...DF........... fd6e0a10: 44000300 00000047 00000000 00000000 ...DG........... fd6e0a20: 44000b00 00000048 00000100 00000000 ...DH........... fd6e0a30: 44000b00 00000049 00000100 00000000 ...DI........... fd6e0a40: 44000300 0000004a 00000000 00000000 ...DJ........... fd6e0a50: 44000300 0000004b 00000000 00000000 ...DK........... fd6e0a60: 44000402 0000004c 00000000 00000000 ...DL........... fd6e0a70: 84000201 0000004d 00000000 00000000 ....M........... fd6e0a80: 44000300 0000004e 00000000 00000000 ...DN........... fd6e0a90: 44000300 0000004f 00000000 00000000 ...DO........... fd6e0aa0: 44000300 00000050 00000000 00000000 ...DP........... fd6e0ab0: 44000300 00024051 00000000 00000000 ...DQ@.......... fd6e0ac0: 44000700 00024052 00000000 00000000 ...DR@.......... fd6e0ad0: 44000300 00000053 00000000 00000000 ...DS........... fd6e0ae0: 44000300 00000054 00000000 00000000 ...DT........... fd6e0af0: 44000300 0003c055 00000000 00000000 ...DU........... fd6e0b00: 44000300 0003c056 00000000 00000000 ...DV........... fd6e0b10: 84000200 00000057 00000000 00000000 ....W........... # ESPI_CLK_LOOPBK fd6e0b20: 40000700 00000000 00000100 00000000 ...@............ ^^ fd6e0b30: 00000000 00000000 00000000 00000000 ................ fd6e0b40: 00000000 00000000 00000000 00000000 ................ fd6e0b50: 00000000 00000000 00000000 00000000 ................ fd6e0b60: 00000000 00000000 00000000 00000000 ................ fd6e0b70: 00000000 00000000 00000000 00000000 ................ fd6e0b80: 00000000 00000000 00000000 00000000 ................ fd6e0b90: 00000000 00000000 00000000 00000000 ................ fd6e0ba0: 00000000 00000000 00000000 00000000 ................ fd6e0bb0: 00000000 00000000 00000000 00000000 ................ fd6e0bc0: 00000000 00000000 00000000 00000000 ................ fd6e0bd0: 00000000 00000000 00000000 00000000 ................ fd6e0be0: 00000000 00000000 00000000 00000000 ................ fd6e0bf0: 00000000 00000000 00000000 00000000 ................
com 1 root@debian:~# memtool md -l 0xfd6d0700+0x500 # GPP_S fd6d0700: 44000300 0180006c 00000000 00000000 ...Dl........... fd6d0710: 44000300 0180006d 00000000 00000000 ...Dm........... fd6d0720: 44000300 0180006e 00000000 00000000 ...Dn........... fd6d0730: 44000300 0180006f 00000000 00000000 ...Do........... fd6d0740: 44000300 01800070 00000000 00000000 ...Dp........... fd6d0750: 44000300 01800071 00000000 00000000 ...Dq........... fd6d0760: 44000100 01800072 00000000 00000000 ...Dr........... fd6d0770: 44000100 01800073 00000000 00000000 ...Ds........... # GPP_H fd6d0780: 44000300 00001074 00000000 00000000 ...Dt........... fd6d0790: 44000300 00001075 00000000 00000000 ...Du........... fd6d07a0: 44000300 00001076 00000000 00000000 ...Dv........... fd6d07b0: 44000100 00001077 00000000 00000000 ...Dw........... fd6d07c0: 44000702 00000018 00000000 00000000 ...D............ fd6d07d0: 44000702 00000019 00000000 00000000 ...D............ fd6d07e0: 44000102 0000001a 00000000 00000000 ...D............ fd6d07f0: 44000300 0000001b 00000000 00000000 ...D............ fd6d0800: 44000100 0000101c 00000100 00000000 ...D............ fd6d0810: 44000100 0000101d 00000100 00000000 ...D............ fd6d0820: 44000300 0000001e 00000000 00000000 ...D............ fd6d0830: 44000300 0000001f 00000000 00000000 ...D............ fd6d0840: 44000300 00000020 00000000 00000000 ...D ........... fd6d0850: 44000300 00000021 00000000 00000000 ...D!........... fd6d0860: 44000300 00000022 00000000 00000000 ...D"........... fd6d0870: 44000300 00000023 00000000 00000000 ...D#........... fd6d0880: 44000700 0003c024 00000000 00000000 ...D$........... fd6d0890: 44000602 0003c025 00000000 00000000 ...D%........... fd6d08a0: 44000700 0003c026 00000000 00000000 ...D&........... fd6d08b0: 44000300 0003c027 00000000 00000000 ...D'........... fd6d08c0: 44000300 00000028 00000000 00000000 ...D(........... fd6d08d0: 44000300 00000029 00000000 00000000 ...D)........... fd6d08e0: 44000300 0000002a 00000000 00000000 ...D*........... fd6d08f0: 44000300 0000002b 00000000 00000000 ...D+........... # GPP_D fd6d0900: 44000201 0000002c 00000000 00000000 ...D,........... fd6d0910: 44000100 0000002d 00000000 00000000 ...D-........... fd6d0920: 44000100 0000102e 00000000 00000000 ...D............ fd6d0930: 44000102 0000002f 00000000 00000000 ...D/........... fd6d0940: 44000300 00000030 00000000 00000000 ...D0........... fd6d0950: 44000702 00000031 00000000 00000000 ...D1........... fd6d0960: 44000702 00000032 00000000 00000000 ...D2........... fd6d0970: 44000702 00000033 00000000 00000000 ...D3........... fd6d0980: 44000702 00000034 00000000 00000000 ...D4........... fd6d0990: 84000301 00000035 00000000 00000000 ....5........... fd6d09a0: 44000300 00000036 00000000 00000000 ...D6........... fd6d09b0: 44000100 00001037 00000000 00000000 ...D7........... fd6d09c0: 44000300 00000038 00000000 00000000 ...D8........... fd6d09d0: 44000300 00000039 00000000 00000000 ...D9........... fd6d09e0: 84000201 0000003a 00000000 00000000 ....:........... fd6d09f0: 44000300 0000003b 00000000 00000000 ...D;........... fd6d0a00: 44000300 0000003c 00000000 00000000 ...D<........... fd6d0a10: 44000100 0000003d 00000000 00000000 ...D=........... fd6d0a20: 44000102 0000003e 00000000 00000000 ...D>........... fd6d0a30: 44000300 0000003f 00000000 00000000 ...D?........... # GSPI2_CLK_LOOPBK fd6d0a40: 40000700 00000000 00000000 00000000 ...@............ ^^ # GPP_U fd6d0a50: 44000300 00000040 00000000 00000000 ...D@........... fd6d0a60: 44000300 00000041 00000000 00000000 ...DA........... fd6d0a70: 44000300 00000042 00000000 00000000 ...DB........... fd6d0a80: 44000300 00000043 00000000 00000000 ...DC........... fd6d0a90: 44000300 00000044 00000000 00000000 ...DD........... fd6d0aa0: 44000300 00000045 00000000 00000000 ...DE........... fd6d0ab0: 44000300 00000046 00000000 00000000 ...DF........... fd6d0ac0: 44000300 00000047 00000000 00000000 ...DG........... fd6d0ad0: 44000300 00000048 00000000 00000000 ...DH........... fd6d0ae0: 44000300 00000049 00000000 00000000 ...DI........... fd6d0af0: 44000300 0000004a 00000000 00000000 ...DJ........... fd6d0b00: 44000300 0000004b 00000000 00000000 ...DK........... fd6d0b10: 44000300 0000004c 00000000 00000000 ...DL........... fd6d0b20: 44000300 0000004d 00000000 00000000 ...DM........... fd6d0b30: 44000300 0000004e 00000000 00000000 ...DN........... fd6d0b40: 44000300 0000004f 00000000 00000000 ...DO........... fd6d0b50: 44000300 00000050 00000000 00000000 ...DP........... fd6d0b60: 44000300 00000051 00000000 00000000 ...DQ........... fd6d0b70: 44000300 00000052 00000000 00000000 ...DR........... fd6d0b80: 44000300 00000053 00000000 00000000 ...DS........... # GSPI3_CLK_LOOPBK fd6d0b90: 40000700 00000000 00000000 00000000 ...@............ # GSPI4_CLK_LOOPBK fd6d0ba0: 40000700 00000000 00000000 00000000 ...@............ # GSPI5_CLK_LOOPBK fd6d0bb0: 40000700 00000000 00000000 00000000 ...@............ # GSPI6_CLK_LOOPBK fd6d0bc0: 40000700 00000000 00000000 00000000 ...@............ # VGPIO fd6d0bd0: 40000200 00000000 00000000 00000000 ...@............ fd6d0be0: 44000102 00000054 00000000 00000000 ...DT........... fd6d0bf0: 40000003 00000000 00000000 00000000 ...@............ fd6d0c00: 40000402 00000000 00000000 00000000 ...@............ fd6d0c10: 40000400 00000000 00000000 00000000 ...@............ fd6d0c20: 40000400 00000000 00000000 00000000 ...@............ fd6d0c30: 40000402 00000000 00000000 00000000 ...@............ fd6d0c40: 40000402 00000000 00000000 00000000 ...@............ fd6d0c50: 40000400 00000000 00000000 00000000 ...@............ fd6d0c60: 40000400 00000000 00000000 00000000 ...@............ fd6d0c70: 40000402 00000000 00000000 00000000 ...@............ fd6d0c80: 40000402 00000000 00000000 00000000 ...@............ fd6d0c90: 40000400 00000000 00000000 00000000 ...@............ fd6d0ca0: 40000400 00000000 00000000 00000000 ...@............ fd6d0cb0: 40000402 00000000 00000000 00000000 ...@............ fd6d0cc0: 40000402 00000000 00000000 00000000 ...@............ fd6d0cd0: 40000400 00000000 00000000 00000000 ...@............ fd6d0ce0: 40000400 00000000 00000000 00000000 ...@............ fd6d0cf0: 40000402 00000000 00000000 00000000 ...@............ fd6d0d00: 40000400 00000000 00000000 00000000 ...@............ fd6d0d10: 40000400 00000000 00000000 00000000 ...@............ fd6d0d20: 40000400 00000000 00000000 00000000 ...@............ fd6d0d30: 40000400 00000000 00000000 00000000 ...@............ fd6d0d40: 40000400 00000000 00000000 00000000 ...@............ fd6d0d50: 40000400 00000000 00000000 00000000 ...@............ fd6d0d60: 40000400 00000000 00000000 00000000 ...@............ fd6d0d70: 40000400 00000000 00000000 00000000 ...@............
fd6d0d80: 00000000 00000000 00000000 00000000 ................ fd6d0d90: 00000000 00000000 00000000 00000000 ................ fd6d0da0: 00000000 00000000 00000000 00000000 ................ fd6d0db0: 00000000 00000000 00000000 00000000 ................ fd6d0dc0: 00000000 00000000 00000000 00000000 ................ ```
-
Michael Niewöhner (Code Review)